Bug 1216200

Summary: Attempting to display the content hosts that have the errata in their life cycle environment failed
Product: Red Hat Satellite Reporter: sthirugn <sthirugn>
Component: Content ManagementAssignee: Walden Raines <walden>
Status: CLOSED CURRENTRELEASE QA Contact: sthirugn <sthirugn>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: bkearney, walden
Target Milestone: UnspecifiedKeywords: Regression
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/10308
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 13:57:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Page loads forever none

Description sthirugn@redhat.com 2015-04-28 18:01:58 UTC
Created attachment 1019813 [details]
Page loads forever

Description of problem:
Attempting to display the content hosts that have the errata in their life cycle environment failed

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-6-20150424.0

How reproducible:
Always

Steps to Reproduce:
1. Go to Content -> Errata
2. Select an errata which is installable in atleast 2 content hosts 
3. Click 'Apply Errata'
4. Check the check box which says "Only show content hosts where $errata is currently installable in the host's Lifecycle Environment."

Actual results:
The UI never loads (screenshot attached).  I saw this error in foreman/production.log
2015-04-28 14:00:39 [I]   Parameters: {"erratum_id"=>"812b13a6-82a2-46e7-ab10-5e752048f653", "organization_id"=>"1", "page"=>1, "search"=>"", "erratum_restrict_installable"=>false, "fields"=>"full", "api_version"=>"v2", "system"=>{}}
2015-04-28 14:00:39 [E] NoMethodError: undefined method `to_bool' for false:FalseClass
/opt/rh/ruby193/root/usr/share/gems/gems/katello-2.2.0.37/app/controllers/katello/api/v2/systems_controller.rb:391:in `systems_by_errata'
/opt/rh/ruby193/root/usr/share/gems/gems/katello-2.2.0.37/app/controllers/katello/api/v2/systems_controller.rb:75:in `index'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/abstract_controller/base.rb:167:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_controller/metal/rendering.rb:10:in `process_action'

Expected results:
Page loads without error

Additional info:

Comment 3 Walden Raines 2015-04-29 14:43:07 UTC
Created redmine issue http://projects.theforeman.org/issues/10308 from this bug

Comment 4 Walden Raines 2015-04-29 14:49:42 UTC
PR: https://github.com/Katello/katello/pull/5198

Comment 5 Walden Raines 2015-05-19 13:52:18 UTC
Required Foreman change merged - https://github.com/theforeman/foreman/commit/c74610f9ae1de9c543dd976c26ee7d81fe6506e6

Comment 6 Bryan Kearney 2015-05-19 16:05:47 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/10308 has been closed
-------------
Walden Raines
Applied in changeset commit:katello|9f2797e3d9540b548e499f714773ead424e1932f.

Comment 7 Bryan Kearney 2015-05-19 16:32:52 UTC
commit 94bc4ac39f4cd230e0eebec2c3c1a5930b745159
Author: Walden Raines <walden>
Date:   Tue May 5 10:56:23 2015 -0400

    Fixes #10402: add to_bool function for converting to boolean.
    
    This commit adds a to_bool function for casting values to boolean
    as well as an example usage.
    
    http://projects.theforeman.org/issues/10402
    (cherry picked from commit c74610f9ae1de9c543dd976c26ee7d81fe6506e6)


commit 4c5b9af92e0ead438ceff6b4d56322d309feb579
Author: Walden Raines <walden>
Date:   Wed Apr 29 10:43:21 2015 -0400

    Fixes #10308: prevent ISE on errata content hosts page BZ1216200.
    
    Add to_bool methods for TrueClass, FalseClass, Fixnum, and NilClass
    in order to prevent undefined method error.
    
    http://projects.theforeman.org/issues/10308
    https://bugzilla.redhat.com/show_bug.cgi?id=1216200
    (cherry picked from commit 9f2797e3d9540b548e499f714773ead424e1932f)
    
    Conflicts:
        lib/monkeys/string_to_bool.rb
        spec/lib/string.rb

Comment 9 sthirugn@redhat.com 2015-05-21 18:20:54 UTC
Verified in Sat 6.1 GA Snap 5.  I am able to view the content hosts that have the errata in their life cycle environment.

Comment 10 Bryan Kearney 2015-08-11 13:32:20 UTC
This bug is slated to be released with Satellite 6.1.

Comment 11 Bryan Kearney 2015-08-12 13:57:56 UTC
This bug was fixed in version 6.1.1 of Satellite which was released on 12 August, 2015.