Bug 1216302

Summary:	Symlink heal leaks 'linkname' memory
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs, jbyers
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1213542	Environment:
Last Closed:	2015-05-14 17:29:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1213542
Bug Blocks:

Description Pranith Kumar K 2015-04-29 05:09:18 UTC

+++ This bug was initially created as a clone of Bug #1213542 +++

Description of problem:
While reading code found that the memory allocated for 'linkname' is not 'free'ed.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a symlink while one of the bricks is offline and the symlink heal leaks memory.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-04-20 13:59:54 EDT ---

REVIEW: http://review.gluster.org/10305 (cluster/afr: Fix memleak in symlink heal) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-04-22 06:53:58 EDT ---

REVIEW: http://review.gluster.org/10305 (cluster/afr,dht: Fix memleak after syncop_readlink) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-04-23 09:55:29 EDT ---

COMMIT: http://review.gluster.org/10305 committed in master by Vijay Bellur (vbellur) 
------
commit 838317e199c6cc11ff5e7094552537f03a8f6313
Author: Pranith Kumar K <pkarampu>
Date:   Mon Apr 20 23:23:55 2015 +0530

    cluster/afr,dht: Fix memleak after syncop_readlink
    
    Change-Id: Ia71c14c2c2709c541075748c9011437e0d8cac4b
    BUG: 1213542
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/10305
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: N Balachandran <nbalacha>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2015-04-29 05:14:35 UTC

REVIEW: http://review.gluster.org/10441 (cluster/afr,dht: Fix memleak after syncop_readlink) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2015-05-01 14:50:34 UTC

COMMIT: http://review.gluster.org/10441 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit e1f675cfd0f5b601c332b17333149d6c760bfd89
Author: Pranith Kumar K <pkarampu>
Date:   Mon Apr 20 23:23:55 2015 +0530

    cluster/afr,dht: Fix memleak after syncop_readlink
    
            Backport of http://review.gluster.org/10305
    
    BUG: 1216302
    Change-Id: Icb0f2d6bbff806e1c5827fabcbf46b9b7983491f
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/10441
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:29:31 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:57 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:18 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:46:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user