Bug 1216881

Summary: OpenDMARC service is enabled by default
Product: [Fedora] Fedora Reporter: Juan Orti Alcaine <jorti>
Component: opendmarcAssignee: Steve Jenkins <steve>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: jorti, steve
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: opendmarc-1.3.1-13.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-08 07:35:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Juan Orti Alcaine 2015-04-29 06:40:45 UTC
Description of problem:
After installing opendmarc, the service is always enabled, independently of the preset settings. This is because the spec file doesn't use the systemd macros.

Version-Release number of selected component (if applicable):
opendmarc-1.3.1-12.fc23

Additional info:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

Comment 1 Steve Jenkins 2015-04-29 14:07:13 UTC
Hi, Juan.

Thanks for your feedback, but I'm unable to reproduce your issue.

Here's the spec file for the version you referenced:

http://pkgs.fedoraproject.org/cgit/opendmarc.git/tree/opendmarc.spec?id=0e043c87e185afce85a6be6814e3961fc7d24f20

If you search for "systemd" you'll see the systemd support provided.

I'm wondering how the service gets enabled in the first place without systemd support?

But if there IS something wrong in the existing macros, any further assistance you can provider in locating it would be appreciated.

Thanks,

SteveJ

Comment 2 Juan Orti Alcaine 2015-04-29 18:28:18 UTC
(In reply to Steve Jenkins from comment #1)
> Hi, Juan.
> 
> Thanks for your feedback, but I'm unable to reproduce your issue.
> 
> Here's the spec file for the version you referenced:
> 
> http://pkgs.fedoraproject.org/cgit/opendmarc.git/tree/opendmarc.
> spec?id=0e043c87e185afce85a6be6814e3961fc7d24f20
> 
> If you search for "systemd" you'll see the systemd support provided.
> 
> I'm wondering how the service gets enabled in the first place without
> systemd support?

https://fedoraproject.org/wiki/Features/PackagePresets

> 
> But if there IS something wrong in the existing macros, any further
> assistance you can provider in locating it would be appreciated.
> 

The systemd macros should be used in Fedora to honor the preset settings and to consistently install services in all the distribution.

Comment 3 Steve Jenkins 2015-04-29 19:58:06 UTC
Gotit. Thanks, Juan.

Changed the spec file to include the following systemd macros on systemd branches:

%post
%systemd_post %{name}.service

%preun
%systemd_preun %{name}.service

%postun
%systemd_postun_with_restart %{name}.service

FYI - I just heard from upstream that a new build is about to be released in the next day or two, so I'm going to hold off and push these changes with the new upstream bits.

Comment 4 Fedora Update System 2015-04-30 01:02:52 UTC
opendmarc-1.3.1-13.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/opendmarc-1.3.1-13.fc22

Comment 5 Fedora Update System 2015-05-01 16:36:59 UTC
Package opendmarc-1.3.1-13.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing opendmarc-1.3.1-13.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-7283/opendmarc-1.3.1-13.fc22
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2015-05-08 07:35:53 UTC
opendmarc-1.3.1-13.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.