Bug 1217157

Summary: login banner placement checks fail to properly detect text overflow
Product: Red Hat Enterprise Linux 7 Reporter: Matthew Gyurgyik <matthew>
Component: gnome-shellAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: jlyle, jraising, jwright, mdomonko, rstrode, tpelka, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gnome-shell-3.14.4-10.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 07:19:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1133060    
Attachments:
Description Flags
/etc/dconf/db/gdm.d/01_banner
none
GDM at 1280x800
none
GDM at 1440x900
none
Screenshot of GNOME-3.14.4 in Fedora 21
none
banner screenshot none

Description Matthew Gyurgyik 2015-04-29 16:34:20 UTC
Created attachment 1020256 [details]
/etc/dconf/db/gdm.d/01_banner

Description of problem:

The banner message is displayed in two different places depending on the resolution.

Location 1: Banner message is on the left hand side of the screen, user/pass text entry box is on the left hand of the screen. (1280x800)

Location 2: Banner message is above the user/pass text entry box. And the user/pass text entry box is centred on the screen. (1440x900, 1680x1050)



Version-Release number of selected component (if applicable):

$ rpm -qa gdm
gdm-3.8.4-32.el7.x86_64


How reproducible:
Always


Steps to Reproduce:
$ create /etc/dconf/db/gdm.d/01_banner (see attached)
$ dconf update


Expected results:
The banner should be displayed in the same location regardless of display resolution.

Comment 1 Matthew Gyurgyik 2015-04-29 16:35:09 UTC
Created attachment 1020257 [details]
GDM at 1280x800

Comment 2 Matthew Gyurgyik 2015-04-29 16:35:43 UTC
Created attachment 1020258 [details]
GDM at 1440x900

Comment 3 Matthew Gyurgyik 2015-04-29 16:52:38 UTC
Errata RHSA-2015-0535 states "* Prior to this update, only a small area was available on the GDM login screen for a custom text banner. As a consequence, when a long banner was used, it did not fit into the area, and the person reading the banner had to use scrollbars to view the whole text. With this update, more space is used for the banner if necessary, which allows the user to read the message conveniently. (BZ#1110036)"

It sound like this change may be related to this problem. Sadly, BZ#1110036 is private and I can not view it.

Comment 5 Ray Strode [halfline] 2015-05-04 14:56:11 UTC
Hi, showing two different layouts depending on screen resolution and message length is actually "by design".  The idea is to only show short messages above, and show long messages on the side.

Clearly, in your case, the message should be on the side in both situations, though.

Comment 7 Michal Domonkos 2015-05-11 16:25:01 UTC
It looks like this wasn't fixed in GNOME-3.14 in its entirety.

Now the text seems to never overflow any more, however, it's always placed on top of the user list, spanning the whole screen horizontally and that doesn't seem to change with the resolution either (screenshot attached).

Comment 8 Michal Domonkos 2015-05-11 16:27:13 UTC
Created attachment 1024275 [details]
Screenshot of GNOME-3.14.4 in Fedora 21

Comment 9 Michal Domonkos 2015-06-02 09:47:20 UTC
On GNOME-3.16 (Fedora 22), I no longer see the issue I had in comment 7.  The banner always sticks to the side of the user list as it should.

Comment 15 Joe Wright 2015-07-29 21:07:11 UTC
Created attachment 1057420 [details]
banner screenshot

Comment 20 errata-xmlrpc 2015-11-19 07:19:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2216.html