Bug 1217158

Summary:	bkr list-systems --group incompatible with system pools in Beaker 20
Product:	[Retired] Beaker	Reporter:	Andrei Stepanov <astepano>
Component:	command line	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	aigao, asaha, dcallagh, dowang
Target Milestone:	20.2	Keywords:	Patch, Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-14 08:04:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrei Stepanov 2015-04-29 16:37:01 UTC

bkr list-systems --group=spice-qe
HTTP error: 500 Server Error: Internal error

beaker-client-19.1-1.fc19.noarch

Comment 1 Dan Callaghan 2015-04-29 23:37:29 UTC

Thanks for the report. There are a few things going wrong here, related to the system groups -> pools transition.

The server should map system group searches to system pool searches, for backwards compatibility with old client versions.

The bkr list-systems command should have been updated to have --pool instead of --group (with --group as a hidden option for backwards compatibility).

Lastly, it seems that searching by pool is not actually returning any results either. I will file a separate bug for that...

Comment 2 Dan Callaghan 2015-04-30 00:48:27 UTC

(In reply to Dan Callaghan from comment #1)
> Lastly, it seems that searching by pool is not actually returning any
> results either. I will file a separate bug for that...

Actually the problem is slightly different. Searching by pools does work correctly.

The problem was that the systems in spice-qe group were "secret" (that is, not visible to all users) and I wasn't logged in, so they were (correctly) excluded from the search results. However the pool page still lists the secret systems even for anonymous users, so I didn't realise they were secret.

Arguably the pool page should not disclose the existence of systems which the user is not allowed to see, although there are lots of other places in Beaker where the same thing happens (job results for example). I filed bug 1217283 for that but I don't see it as a serious issue.

Comment 3 Dan Callaghan 2015-05-08 06:07:01 UTC

(In reply to Dan Callaghan from comment #1)
> The server should map system group searches to system pool searches, for
> backwards compatibility with old client versions.

http://gerrit.beaker-project.org/4205

> The bkr list-systems command should have been updated to have --pool instead
> of --group (with --group as a hidden option for backwards compatibility).

http://gerrit.beaker-project.org/4206

Comment 4 Dan Callaghan 2015-05-12 01:16:59 UTC

Steps to reproduce:
1. Install version 19.x of beaker-client, pointing at 20.x of beaker-server
2. Run: bkr list-systems --group=<somegroup>

Expected results:
Listing should work, should return the systems in the pool named after <somegroup> which will be the systems that were in the group prior to the 20.0 migration.

3. Install latest version of beaker-client
4. Run: bkr list-systems --group=<somegroup>

Expected results:
As above. However --group is not listed in the --help for bkr list-systems as it is deprecated.

5. Run: bkr list-systems --pool=<somepool>

Expected results:
As above.

Comment 7 Dan Callaghan 2015-07-14 08:04:48 UTC

Beaker 20.2 has been released.