Bug 1217194

Summary: [1.2.14] Some configuration files are not installed from the sources
Product: [Community] Virtualization Tools Reporter: jean-christophe manciot <actionmystique>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED NOTABUG QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: eblake, jdenemar, rbalakri
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-30 08:21:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description jean-christophe manciot 2015-04-29 18:06:59 UTC
Description of problem:
----------------------
If I install libvirt-bin from an official Ubuntu repository, all the following libvirt conf files are installed in /etc:
./logrotate.d/libvirtd
./logrotate.d/libvirtd.qemu
./logrotate.d/libvirtd.uml
./logrotate.d/libvirtd.lxc
./sasl2/libvirt.conf
./libvirt
./cron.daily/libvirt-bin
./default/libvirt-bin
./init/libvirt-bin.conf
./dnsmasq.d-available/libvirt-bin
./dnsmasq.d/libvirt-bin.bak
./dnsmasq.d/libvirt-bin
./apparmor.d/libvirt
./apparmor.d/abstractions/libvirt-qemu
./apparmor.d/abstractions/libvirt-lxc
./init.d/libvirt-bin

When I completely remove the previous package, manually compile the sources and install the package, none of them are installed in /etc.
Am I missing something?

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
1.2.14

How reproducible:
-----------------
Completely remove the libvirt-bin package, download, compile the sources and install the package
I configured with the following options, but I don't think it is relevant here:
./configure --with-lxc \
            --without-wireshark-dissector \
            --with-apparmor \
            --with-apparmor-mount \
            --with-apparmor-profiles \
            --with-secdriver-apparmor

Additional info:
---------------
Ubuntu Server 15.04

Comment 1 Eric Blake 2015-04-29 19:01:15 UTC
Yes, you are missing things like --prefix=/usr --sysconfdir=/etc as part of your configure arguments.  To install the same files as the pre-built distro, you have to use the same configure arguments.  Since you didn't specify any alternate location, libvirt was configured to use the defaults of /usr/local, and the files you are asking about got installed under /usr/local/etc.

This is not a bug in libvirt proper, but in your configure arguments, so I'm closing this BZ.

Comment 2 Eric Blake 2015-04-29 19:02:58 UTC
Oh, and on Fedora-based systems, './autogen.sh --system' is a great way to pre-set all the configure arguments that match the settings used by the system build. However, I don't know if Ubuntu uses the same arguments (and no one has yet proposed a Debian-based-distro patch to autogen.sh, even though it has been mentioned on the upstream list that it would be accepted).

Comment 3 jean-christophe manciot 2015-04-30 08:03:45 UTC
Yes, you are right for some of the files, but not all of them:

./cron.daily/libvirt-bin
./default/libvirt-bin
./init/libvirt-bin.conf
./dnsmasq.d-available/libvirt-bin
./dnsmasq.d/libvirt-bin
./init.d/libvirt-bin

are not in /usr/local/etc

Comment 4 Jiri Denemark 2015-04-30 08:21:24 UTC
All these files are specific to Ubuntu and are not present upstream. If you want them upstream, ask libvirt maintainers in Ubuntu to submit patches with these files upstream.

Comment 5 jean-christophe manciot 2015-05-01 13:59:18 UTC
It's done, but to be honest, I don't understand exactly what you imply with "submit patches with these files upstream": does that mean that once the libvirt maintainers in Ubuntu will have done this job, we'll be able to get all the missing files when compiling your sources in Ubuntu - previously configured with a special option?