Bug 1217346
Summary: | FreeIPA trusts to AD broken due to Samba 4.2 failure to run LSARPC pipe externally | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alexander Bokovoy <abokovoy> |
Component: | samba | Assignee: | Guenther Deschner <gdeschner> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 22 | CC: | abokovoy, asn, gdeschner, jlayton, madam, sbose, ssorce |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | samba-4.2.1-7.fc22 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-05-03 17:20:08 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Alexander Bokovoy
2015-04-30 08:01:12 UTC
Guenther and I found actual issue -- rpc_create_tcpip_sockets() passed empty string (non-NULL, '') to dcerpc_binding_vector_add_port() and then dcerpc_binding_vector_add_port() tried to set binding's option 'host' to this string. With the commit 017338a1 which is also 4.2 only, setting empty string to special properties of the binding is not possible: + if (value[0] == '\0') { + return NT_STATUS_INVALID_PARAMETER_MIX; + } + Following patch fixed the issue for us: commit 1ff9ffea061e4bdecea65749d8d0e3c082e25d77 Author: Günther Deschner <gd> AuthorDate: Thu Apr 30 11:20:58 2015 +0200 Commit: Günther Deschner <gd> CommitDate: Thu Apr 30 11:22:26 2015 +0200 s3-rpc_server: fix rpc_create_tcpip_sockets() processing of interfaces. We were supplying an empty value for the "host" binding string option, causing dcerpc_binding_vector_add_port() call to fail. Guenther Signed-off-by: Günther Deschner <gd> Pair-Programmed-With: Alexander Bokovoy <ab> --- source3/rpc_server/rpc_sock_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/rpc_server/rpc_sock_helper.c b/source3/rpc_server/rpc_sock_helper.c index 8f371b8..7aced63 100644 --- a/source3/rpc_server/rpc_sock_helper.c +++ b/source3/rpc_server/rpc_sock_helper.c @@ -138,7 +138,7 @@ NTSTATUS rpc_create_tcpip_sockets(const struct ndr_interface_table *iface, if (bvec != NULL) { status = dcerpc_binding_vector_add_port(iface, bvec, - sock_ptr, + sock_tok, p); if (!NT_STATUS_IS_OK(status)) { close(fd); Cloned bug to Samba bugzilla. samba-4.2.1-7.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/samba-4.2.1-7.fc22 Package samba-4.2.1-7.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing samba-4.2.1-7.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-7318/samba-4.2.1-7.fc22 then log in and leave karma (feedback). samba-4.2.1-7.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |