Bug 1217348

Summary:	Saving log depot configuration throws undefined local variable or method `validate_uri_settings' for #<OpsController:0x00000013bfa8e8> [ops/log_depot_edit]
Product:	Red Hat CloudForms Management Engine	Reporter:	Milan Falešník <mfalesni>
Component:	UI - OPS	Assignee:	Aparna Karve <akarve>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.4.0	CC:	hkataria, jhardy, mpovolny, obarenbo
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 13:01:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Falešník 2015-04-30 08:02:00 UTC

Description of problem:
This prevents saving the log depot settings, apparently for every type of them and error appears for saving, even though eg. FTP credentials get verified correctly.

Version-Release number of selected component (if applicable):
5.4.0.0.24

How reproducible:
always

Steps to Reproduce:
1. Go to the log depot page (Configuration/Diagnostics/Collect logs)
2. Click Edit
3. Enter data (I used RH Dropbox, FTP, NFS, all of these failed)
4. Click Save

Actual results:
undefined local variable or method `validate_uri_settings' for #<OpsController:0x00000013bfa8e8> [ops/log_depot_edit]

Expected results:
Configuration was saved.

Additional info:

Comment 2 Aparna Karve 2015-05-01 14:33:11 UTC

PR -
https://github.com/ManageIQ/manageiq/pull/2803

Comment 3 CFME Bot 2015-05-06 21:00:57 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/5c325882e839e9e9f4e6cb1e7bdc037373d47d82

commit 5c325882e839e9e9f4e6cb1e7bdc037373d47d82
Author:     Aparna Karve <akarve>
AuthorDate: Mon Apr 27 13:47:06 2015 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Wed May 6 10:45:54 2015 -0700

    Converted log collection form to Angular
    
    log collection was making references to @edit which has been removed
    from other forms that use FileDepot
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1217348

 vmdb/app/assets/javascripts/application.js         |   1 +
 .../ops/log_collection_form_controller.js          | 100 +++++++++++
 .../javascripts/services/miq_db_backup_service.js  |  50 +++++-
 .../app/assets/javascripts/services/miq_service.js |  11 ++
 vmdb/app/controllers/ops_controller.rb             |   3 +-
 vmdb/app/controllers/ops_controller/diagnostics.rb | 189 ++++++++-------------
 .../_edit_log_depot_settings_angular.html.haml     |  16 +-
 vmdb/app/views/ops/_log_collection.html.haml       |  52 ++++++
 vmdb/config/routes.rb                              |   1 +
 .../ops/log_collection_form_controller_spec.js     |  82 +++++++++
 .../services/miq_db_backup_service_spec.js         |  89 ++++++++++
 vmdb/spec/javascripts/services/miq_service_spec.js |  24 +++
 vmdb/spec/javascripts/support/jasmine.yml          |   1 +
 vmdb/spec/routing/ops_routing_spec.rb              |   1 +
 14 files changed, 492 insertions(+), 128 deletions(-)
 create mode 100644 vmdb/app/assets/javascripts/controllers/ops/log_collection_form_controller.js
 create mode 100644 vmdb/app/views/ops/_log_collection.html.haml
 create mode 100644 vmdb/spec/javascripts/controllers/ops/log_collection_form_controller_spec.js
 create mode 100644 vmdb/spec/javascripts/services/miq_db_backup_service_spec.js

Comment 4 Milan Falešník 2015-05-12 12:00:15 UTC

Can save all kinds of log depot configuration on 5.4.0.0.26

Comment 7 errata-xmlrpc 2015-06-16 13:01:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html