Bug 12174
Summary: | LDAP and Kerberos settings not remembered with Back button | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | James Manning <jmm> | ||||
Component: | anaconda | Assignee: | Brock Organ <borgan> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Brock Organ <borgan> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 7.1 | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2000-07-14 15:21:21 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
James Manning
2000-06-12 23:18:18 UTC
Fairly clear that Kerb and LDAP got tacked on and didn't get the nice treatment that the others did :) In particular, anaconda/iw/auth_gui.py's AuthWindow class's getScreen method. lines 84-90 are the in-place calls to restore the settings for the appropriate GtkEntry's and GtkCheckButton's. Those restorations never got put in for the added Kerb and LDAP sections. Hence, one correct fix appears to be: --- anaconda-beta2/iw/auth_gui.py.orig Mon Jun 26 21:11:53 2000 +++ anaconda-beta2/iw/auth_gui.py Mon Jun 26 21:20:18 2000 @@ -123,6 +123,11 @@ self.ldapBasednLabel = GtkLabel (_("LDAP Base DN:")) self.ldapBasednLabel.set_alignment (0, 0) + # restore ldap settings + self.ldap.set_active (self.todo.auth.useLdap) + self.ldapServer.set_text (self.todo.auth.nisDomain) + self.ldapBasedn.set_text (self.todo.auth.self.todo.auth.ldapBasedn) + ldaptable = GtkTable (10, 4) ldaptable.attach (self.ldap, 0, 10, 0, 1) @@ -152,6 +157,12 @@ self.krb5KdcLabel.set_alignment (0, 0) self.krb5AdminLabel = GtkLabel (_("Admin Server:")) self.krb5AdminLabel.set_alignment (0, 0) + + # restore krb5 settings + self.krb5.set_active (self.todo.auth.useKrb5) + self.self.krb5Realm.set_text (self.todo.auth.krb5Realm) + self.self.krb5Kdc.set_text (self.todo.auth.krb5Kdc) + self.self.krb5Admin.set_text (self.todo.auth.krb5Admin) krb5table = GtkTable (10, 4) Whoops... as you can see from the "nisDomain" mentioned in ldapServer.set_text of the above patch, I did a little cut and paste and missed one of the changes. I even screwed up the Basedn assignment after that! :) Sorry about that... I'll get more sleep next time :) --- anaconda-beta2/iw/auth_gui.py.orig Mon Jun 26 21:11:53 2000 +++ anaconda-beta2/iw/auth_gui.py Mon Jun 26 22:52:14 2000 @@ -123,6 +123,11 @@ self.ldapBasednLabel = GtkLabel (_("LDAP Base DN:")) self.ldapBasednLabel.set_alignment (0, 0) + # restore ldap settings + self.ldap.set_active (self.todo.auth.useLdap) + self.ldapServer.set_text (self.todo.auth.ldapServer) + self.ldapBasedn.set_text (self.todo.auth.ldapBasedn) + ldaptable = GtkTable (10, 4) ldaptable.attach (self.ldap, 0, 10, 0, 1) @@ -152,6 +157,12 @@ self.krb5KdcLabel.set_alignment (0, 0) self.krb5AdminLabel = GtkLabel (_("Admin Server:")) self.krb5AdminLabel.set_alignment (0, 0) + + # restore krb5 settings + self.krb5.set_active (self.todo.auth.useKrb5) + self.self.krb5Realm.set_text (self.todo.auth.krb5Realm) + self.self.krb5Kdc.set_text (self.todo.auth.krb5Kdc) + self.self.krb5Admin.set_text (self.todo.auth.krb5Admin) krb5table = GtkTable (10, 4) Created attachment 758 [details]
Adds setting restorations for LDAP and Krb5 settings
Applied patches - thanks! Please verify in test lab. verified fix in TUI & GUI mode ... |