Bug 1217588

Summary:	pass multiple gears to oo-admin-move and provide final output in json
Product:	OpenShift Container Platform	Reporter:	Brenton Leanhardt <bleanhar>
Component:	Node	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	high
Version:	2.2.0	CC:	abhgupta, adellape, agrimm, anli, jokerman, libra-bugs, libra-onpremise-devel, mmccomas, pruan, tiwillia, xiama
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-origin-broker-util-1.34.1.1-1.el6op, rubygem-openshift-origin-msg-broker-mcollective-1.34.1.1-1	Doc Type:	Bug Fix
Doc Text:	When moving multiple gears with the oo-admin-move command, the command would previously fail if a single gear could not be found by the provided UUID. Additionally, failures and source server identities were not reported properly in JSON when the --json option was specified. This bug fix updates the command to report an error individually for each gear unable to be found. The rest of the valid gears are still moved properly. JSON output also now includes source server identities, and failures while the --json option is specified are reported in JSON.	Story Points:	---
Clone Of:	1212614	Environment:
Last Closed:	2015-07-21 19:12:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1212614
Bug Blocks:

Description Brenton Leanhardt 2015-04-30 18:13:16 UTC

OpenShift Enterprise never shipped the bug described in Bug #1212614.  This bug is simply to document the new feature in OSE and to ensure that regression testing happens.


+++ This bug was initially created as a clone of Bug #1212614 +++

Description of problem:

The recently added code to allow oo-admin-move to take multiple gears aborts if a single gear is not found.

Version-Release number of selected component (if applicable):

openshift-origin-broker-util-1.34.2-1.el6oso.noarch

How reproducible:

Always

Steps to Reproduce:

1) oo-admin-move --gear_uuid 01234,<valid uuid>

Actual results:

ERROR: Gear not found: 01234

Expected results:

ERROR: Gear not found: 01234
followed by a move of the valid gear.

Additional info:
I will create a PR for this.

--- Additional comment from Andy Grimm on 2015-04-16 16:33:29 EDT ---

master PR:

https://github.com/openshift/origin-server/pull/6125/

stage PR:

https://github.com/openshift/origin-server/pull/6126

--- Additional comment from openshift-github-bot on 2015-04-17 13:43:47 EDT ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/2bc7d563f4e2b26e95d2e4f6b21fa1de86d1b53e
Bug 1212614 - Various oo-admin-move issues

  * command failed when --json was not specified
  * command aborted prematurely if a single gear in a list was not found
  * destination server was not properly reported unless explicitly specified
  * source server identity is now also captured in json output

Comment 4 Ma xiaoqiang 2015-05-07 02:38:59 UTC

Check on puddle [2.2.5/2015-05.06.4]

1. create an app
# rhc app create xiaom1 php-5.4 
# rhc app create xiaom2 perl
2. move gear with multi-gears
# oo-admin-move --gear_uuid test,xiaom-xiaom1
ERROR: Gear not found: test
ERROR: Gear not found: xiaom-xiaom1
# oo-admin-move --gear_uuid test,xiaom-xiaom1-1
ERROR: Gear not found: test
move xiaom-xiaom1-1
# oo-admin-move --gear_uuid xiaom-xiaom1-1,test,xiaom-xiaom2-1
ERROR: Gear not found: test
move xiaom-xiaom1-1,xiaom-xiaom2-1

Comment 6 errata-xmlrpc 2015-07-21 19:12:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1463.html