Bug 1217786

Summary:	Data Tiering : Adding performance to unlink/link/rename in CTR Xlator
Product:	[Community] GlusterFS	Reporter:	Joseph Elwin Fernandes <josferna>
Component:	tiering	Assignee:	Joseph Elwin Fernandes <josferna>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Joseph Elwin Fernandes <josferna>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, sankarshan
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1219066 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:57:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1219066, 1260923

Description Joseph Elwin Fernandes 2015-05-01 15:57:06 UTC

Description of problem:
ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops

1) ctr_link_consistency option for ctr xaltor is provided so that
   the user can choose to switch it on or off.
   /* For link consistency we do a double update i.e mark the link
   * during the wind and during the unwind we update/delete the link.
   * This has a performance hit. We give a choice here whether we need
   * link consistency to be spoton or not using link_consistency flag.
   * This will have only one link update */
2) In delete the wind time recording is moved to unwind path.
   /* Special performance case:
   * Updating wind time in unwind for delete. This is done here
   * as in the wind path we will not know whether its the last
   * link or not. For a last link there is not use to update any
   * wind or unwind time!*/

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-05-01 15:57:29 UTC

REVIEW: http://review.gluster.org/10170 (ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops) posted (#3) for review on master by Joseph Fernandes (josferna)

Comment 2 Anand Avati 2015-05-01 16:10:37 UTC

COMMIT: http://review.gluster.org/10170 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 4d118cb5ee99b8401d70678fc3b3576ad938999d
Author: Joseph Fernandes <josferna>
Date:   Thu Apr 9 15:07:54 2015 +0530

    ctr/libgfdb: Performance enhancer for unlink/create/rename/link fops
    
    1) ctr_link_consistency option for ctr xaltor is provided so that
       the user can choose to switch it on or off.
       /* For link consistency we do a double update i.e mark the link
       * during the wind and during the unwind we update/delete the link.
       * This has a performance hit. We give a choice here whether we need
       * link consistency to be spoton or not using link_consistency flag.
       * This will have only one link update */
    
    2) In delete the wind time recording is moved to unwind path.
       /* Special performance case:
       * Updating wind time in unwind for delete. This is done here
       * as in the wind path we will not know whether its the last
       * link or not. For a last link there is not use to update any
       * wind or unwind time!*/
    
    Change-Id: I209472fb816f939db4a868b97ba053b028f17ea6
    BUG: 1217786
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/10170
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Niels de Vos 2015-05-15 13:07:29 UTC

This change should not be in "ON_QA", the patch posted for this bug is only available in the master branch and not in a release yet. Moving back to MODIFIED until there is an beta release for the next GlusterFS version.

Comment 4 Nagaprasad Sathyanarayana 2015-10-25 15:03:04 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 5 Niels de Vos 2016-06-16 12:57:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user