Bug 1217835

Summary: exit code from rhn-migrate-classic-to-rhsm activation-key without an org should be EX_USAGE
Product: Red Hat Enterprise Linux 6 Reporter: John Sefler <jsefler>
Component: subscription-managerAssignee: Chris "Ceiu" Rog <crog>
Status: CLOSED ERRATA QA Contact: John Sefler <jsefler>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.7CC: bkearney, crog, skallesh, wpoteat
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-22 06:53:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1125249    

Description John Sefler 2015-05-01 20:21:46 UTC 
Description of problem:
The stderr/exitCode thrown by "rhn-migrate-classic-to-rhsm --activation-key=foo" without specifying --org is not consistent with the rest of subscription-manager.

[root@ibm-z10-08 ~]# rhn-migrate-classic-to-rhsm --activation-key=foo
The --activation-key option requires that a --org be given.
[root@ibm-z10-08 ~]# echo $?
1

Example of a command that throws a better exitCode

[root@ibm-z10-08 ~]# subscription-manager list --no-overlap
Error: --no-overlap is only applicable with --available
[root@ibm-z10-08 ~]# echo $?
64



Version-Release number of selected component (if applicable):
[root@ibm-z10-08 ~]# rpm -q subscription-manager-migration
subscription-manager-migration-1.14.5-1.el6.s390x


How reproducible:


Steps to Reproduce:
[root@ibm-z10-08 ~]# rhn-migrate-classic-to-rhsm --activation-key=foo
The --activation-key option requires that a --org be given.
[root@ibm-z10-08 ~]# echo $?
1

Actual results:
exitCode 1

Expected results:
exitCode 64 from python EX_USAGE
Comment 1 Chris "Ceiu" Rog 2015-05-04 19:09:21 UTC 
commit 270f2a3e5f7d55b69a6f98c160d38362961b3059
Author: Chris Rog <crog>
Date:   Mon May 4 11:44:10 2015 -0400

    Specified error codes on system_exit in rhn-migrate-classic-to-rhsm
    
    - Many calls to system_exit now specify an error code on exit instead
      of using a common non-zero value
Comment 3 Shwetha Kallesh 2015-05-20 08:56:19 UTC 
Exit code is now changed to 64 from 1

[root@cisco-c210-01 ~]# rpm -qa | grep subscription-manager
subscription-manager-migration-1.14.7-1.el6.x86_64
subscription-manager-1.14.7-1.el6.x86_64


[root@cisco-c210-01 ~]#  rhn-migrate-classic-to-rhsm --activation-key=foo
The --activation-key option requires that a --org be given.
[root@cisco-c210-01 ~]# echo $?
64
Comment 4 errata-xmlrpc 2015-07-22 06:53:58 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1345.html