Bug 1218060
| Summary: | [SNAPSHOT]: Initializing snap_scheduler from all nodes at the same time should give proper error message | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | senaik | |
| Component: | snapshot | Assignee: | Avra Sengupta <asengupt> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, bugs, gluster-bugs | |
| Target Milestone: | --- | Keywords: | Reopened, Triaged | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | Scheduler | |||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1223203 1224249 1230018 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-16 12:57:38 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1186580, 1223203, 1224249, 1230018 | |||
Same issue seen while checking snap_scheduler.py status from all nodes at the same time
Node1:
======
snap_scheduler.py status
snap_scheduler: Snapshot scheduling status: Disabled
Node2,Node3, Node4:
===================
snap_scheduler.py status
Traceback (most recent call last):
File "/usr/sbin/snap_scheduler.py", line 575, in <module>
sys.exit(main())
File "/usr/sbin/snap_scheduler.py", line 545, in main
os.makedirs(LOCK_FILE_DIR)
File "/usr/lib64/python2.6/os.py", line 157, in makedirs
mkdir(name, mode)
OSError: [Errno 17] File exists: '/var/run/gluster/shared_storage/snaps/lock_files/'
REVIEW: http://review.gluster.org/11087 (snapshot/scheduler: Handle OSError in os. callbacks) posted (#1) for review on master by Avra Sengupta (asengupt) COMMIT: http://review.gluster.org/11087 committed in master by Krishnan Parthasarathi (kparthas) ------ commit d835219a30327ede60e4ef28210914ab30bd0712 Author: Avra Sengupta <asengupt> Date: Thu Jun 4 17:17:13 2015 +0530 snapshot/scheduler: Handle OSError in os. callbacks Handle OSError and not IOError in os. callbacks. Change-Id: I2b5bfb629bacbd2d2e410d96034b4e2c11c4931e BUG: 1218060 Signed-off-by: Avra Sengupta <asengupt> Reviewed-on: http://review.gluster.org/11087 Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Aravinda VK <avishwan> Reviewed-by: Krishnan Parthasarathi <kparthas> Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well. This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: ======================= Initialising snap_scheduler from all nodes at the same time should fail with proper error message - "Another snap scheduler command is running" Version-Release number of selected component (if applicable): ============================================================== glusterfs 3.7.0beta1 built on May 1 2015 How reproducible: ================= always Steps to Reproduce: =================== 1.Create a dist rep volume and mount it. 2.Create another shared storage volume and mount it under /var/run/gluster/shared_storage 3.Initialise snap scheduler at the same time from all nodes NOde1: ~~~~~ snap_scheduler.py init snap_scheduler: Successfully inited snapshot scheduler for this node Node2, Node3, Node4 : ~~~~~~~~~~~~~~~~~~~~ snap_scheduler.py init Traceback (most recent call last): File "/usr/sbin/snap_scheduler.py", line 574, in <module> sys.exit(main()) File "/usr/sbin/snap_scheduler.py", line 544, in main os.makedirs(LOCK_FILE_DIR) File "/usr/lib64/python2.6/os.py", line 157, in makedirs mkdir(name, mode) OSError: [Errno 17] File exists: '/var/run/gluster/shared_storage/snaps/lock_files/' It should fail with error : snap_scheduler: Another snap_scheduler command is running. Please try again after some time. Actual results: Expected results: Additional info: