Bug 1218431

Summary: Remove unused options from hammer content-view version incremental-update
Product: Red Hat Satellite Reporter: sthirugn <sthirugn>
Component: HammerAssignee: Eric Helms <ehelms>
Status: CLOSED CURRENTRELEASE QA Contact: sthirugn <sthirugn>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: bbuckingham, bkearney, ehelms, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/10600
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 16:04:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sthirugn@redhat.com 2015-05-04 21:29:03 UTC
Description of problem:
Remove unused options from hammer content-view version incremental-update

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150429.2

How reproducible:
Always

Steps to Reproduce:
# hammer -u admin -p changeme content-view version incremental-update --help
Usage:
    hammer content-view version incremental-update [OPTIONS]

Options:
 --async                                                               Do not wait for the task
 --content-view-version CONTENT_VIEW_VERSION_VERSION                   Content view version number
 --content-view-version-environments CONTENT_VIEW_VERSION_ENVIRONMENTS Comma separated list of values.
 --content-view-version-id CONTENT_VIEW_VERSION_ID                     Content view version identifier
 --description DESCRIPTION                                             The description for the new generated Content View Versions
 --environment-ids ENVIRONMENTS                                        list of environment IDs to update the content view version in
                                                                       Comma separated list of values.
 --environments ENVIRONMENT_NAMES                                      Comma separated list of values.
 --errata-ids ERRATA_IDS                                               Errata uuids to copy into the new versions.
                                                                       Comma separated list of values.
 --id ID                                                               ID of a content view version to incrementally update
...
...
...

Actual results:
--content-view-version-environments is a dupe of --environment-ids
--content-view-version-id           is a dupe of --id

Expected results:
Remove unused/dupe options:
--content-view-version-environments
--content-view-version-id


Additional info:
These options are not used and is very confusing.

Comment 1 sthirugn@redhat.com 2015-05-04 21:36:50 UTC
This bug was created while verifying https://bugzilla.redhat.com/show_bug.cgi?id=1201021

Comment 3 Eric Helms 2015-05-22 19:52:34 UTC
Created redmine issue http://projects.theforeman.org/issues/10600 from this bug

Comment 4 Eric Helms 2015-05-22 19:57:02 UTC
Proposed fix here: https://github.com/Katello/hammer-cli-katello/pull/295


Surech, please let me know what you think of this new output:

vagrant@katello-devel hammer-cli-katello (fixes-10600)$ hammer content-view version incremental-update --help
Usage:
    hammer content-view version incremental-update [OPTIONS]

Options:
 --async                                             Do not wait for the task
 --content-host-ids CONTENT_HOST_IDS                 IDs of content hosts to update
                                                     Comma separated list of values.
 --content-view-version CONTENT_VIEW_VERSION_VERSION Content view version number
 --content-view-version-id CONTENT_VIEW_VERSION_ID   Content view version identifier
 --description DESCRIPTION                           The description for the new generated Content View Versions
 --environment-ids ENVIRONMENTS                      list of environment IDs to update the content view version in
                                                     Comma separated list of values.
 --environments ENVIRONMENT_NAMES                    Comma separated list of values.
 --errata-ids ERRATA_IDS                             Errata uuids to copy into the new versions.
                                                     Comma separated list of values.
 --id ID                                             ID of a content view version to incrementally update
 --package-ids PACKAGE_IDS                           Package uuids to copy into the new versions.
                                                     Comma separated list of values.
 --packages PACKAGE_NAMES                            Comma separated list of values.
 --propagate-all-composites PROPAGATE_ALL_COMPOSITES If true, will publish a new composite version using any specified content_view_version_id that has been promoted to a lifecycle environment.
                                                     One of true/false, yes/no, 1/0.
 --puppet-module-ids PUPPET_MODULE_IDS               Puppet Modules to copy into the new versions.
                                                     Comma separated list of values.
 --puppet-modules PUPPET_MODULE_NAMES                Comma separated list of values.
 --resolve-dependencies RESOLVE_DEPENDENCIES         If true, when adding the specified errata or packages, any needed dependencies will be copied as well.
                                                     One of true/false, yes/no, 1/0.
 --search SEARCH                                     Search string for systems to perform an action on
 --update-all-systems UPDATE_ALL_SYSTEMS             Update all editable and applicable systems, not just ones using the selected Content View Versions and Environments
                                                     One of true/false, yes/no, 1/0.
 -h, --help                                          print help

Comment 5 sthirugn@redhat.com 2015-05-23 03:41:01 UTC
Are the following options not corresponding to the same id?

--content-view-version-id CONTENT_VIEW_VERSION_ID   Content view version identifier
--id ID                                             ID of a content view version to incrementally update

Comment 6 Eric Helms 2015-05-26 12:34:58 UTC
They are - if you would prefer one, which one?

Comment 7 sthirugn@redhat.com 2015-05-26 13:17:37 UTC
(In reply to Eric Helms from comment #6)
> They are - if you would prefer one, which one?

I think we can go with --content-view-version-id. Because using --id may confuse users between content view id and content view version id.

Comment 8 Bryan Kearney 2015-06-15 14:39:25 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/10600 has been closed
-------------
Eric Helms
Applied in changeset commit:hammer-cli-katello|30b9ceff88462c265af4de3376145a5a7c08c3d2.

Comment 10 Bryan Kearney 2015-06-26 14:32:31 UTC
Delivered in Snap10

Comment 11 sthirugn@redhat.com 2015-07-07 20:47:26 UTC
Verified in Sat 6.1 GA Snap 11

Usage:
     content-view version incremental-update [OPTIONS]

Options:
 --async                                             Do not wait for the task
 --content-host-ids CONTENT_HOST_IDS                 IDs of content hosts to update
                                                     Comma separated list of values.
 --content-view-version CONTENT_VIEW_VERSION_VERSION Content view version number
 --content-view-version-id CONTENT_VIEW_VERSION_ID   Content view version identifier
 --description DESCRIPTION                           The description for the new generated Content View Versions
 --environment-ids ENVIRONMENTS                      list of environment IDs to update the content view version in
                                                     Comma separated list of values.
 --environments ENVIRONMENT_NAMES                    Comma separated list of values.
 --errata-ids ERRATA_IDS                             Errata uuids to copy into the new versions.
                                                     Comma separated list of values.
 --package-ids PACKAGE_IDS                           a package identifier
                                                     Comma separated list of values.
 --packages PACKAGE_NAMES                            Comma separated list of values.
 --propagate-all-composites PROPAGATE_ALL_COMPOSITES If true, will publish a new composite version using any specified
                                                     content_view_version_id that has been promoted to a lifecycle environment.
                                                     One of true/false, yes/no, 1/0.
 --puppet-module-ids PUPPET_MODULE_IDS               a puppet module identifier
                                                     Comma separated list of values.
 --puppet-modules PUPPET_MODULE_NAMES                Comma separated list of values.
 --resolve-dependencies RESOLVE_DEPENDENCIES         If true, when adding the specified errata or packages, any needed
                                                     dependencies will be copied as well.
                                                     One of true/false, yes/no, 1/0.
 --search SEARCH                                     Search string for systems to perform an action on
 --update-all-systems UPDATE_ALL_SYSTEMS             Update all editable and applicable systems, not just ones using the
                                                     selected Content View Versions and Environments
                                                     One of true/false, yes/no, 1/0.
 -h, --help                                          print help

Comment 12 Bryan Kearney 2015-08-12 16:04:31 UTC
This bug was fixed in Satellite 6.1.1 which was delivered on 12 August, 2015.