Bug 1218674

Summary: [RFE][TEXT] - During restore alert user that objects might be missing in the system afterwards.
Product: [oVirt] ovirt-engine Reporter: Yaniv Lavi <ylavi>
Component: Backup-Restore.EngineAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Gonza <grafuls>
Severity: medium Docs Contact:
Priority: medium    
Version: ---CC: bugs, didi, grafuls, lsurette, oourfali, pstehlik, rbalakri, sbonazzo, srevivo, ykaul
Target Milestone: ovirt-4.0.0-betaKeywords: EasyFix, FutureFeature
Target Release: 4.0.0Flags: rule-engine: ovirt-4.0.0+
grafuls: testing_plan_complete-
ylavi: planning_ack+
sbonazzo: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:41:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaniv Lavi 2015-05-05 14:20:26 UTC
Description of problem:
engine should alert the user that object might be missing since last backup in a DR use case. This is to let the admin know that more step are needed for a full state restoration like importing unregistered VMs and disks.

Comment 1 Yedidyah Bar David 2015-05-06 05:54:53 UTC
IOW, one or more components (engine-backup --mode=restore, engine-setup, the engine itself) should compare the time of restore with the time of backup (as seen in the backup file or in the db) and alert if the difference is "too large".

Comment 2 Sandro Bonazzola 2015-05-08 15:30:38 UTC
If it's the engine that should alert, looks more like a infra issue than an integration issue. Oved?

Comment 3 Oved Ourfali 2015-05-08 17:01:36 UTC
According to comment #1 it can be neither or both. To be honest, don't really see the purpose of this RFE. Anyone who knows what backup is knows that when restoring then you go back to what was there at the time of the backup....  If the purpose is indeed to do what Didi said, then I see no reason to do that on the engine side. The restore option can compare dates.

Comment 4 Sandro Bonazzola 2015-05-14 15:54:30 UTC
I agree with Oved on this, I'm for not a bug.

Comment 5 Sandro Bonazzola 2015-05-14 15:56:17 UTC
Also, if I remember correctly, an engine-setup run is required as part of the restore procedure.
So if something is missing in (terms of configuration), the setup might probably able to fix it.

Comment 6 Yaniv Lavi 2015-06-21 15:21:03 UTC
This is about objects missing and there is no need to compare timestamps since any revert to backup means that something can be lost like VM, disks and so on.
This can be prompt in the restore as well.

Comment 7 Red Hat Bugzilla Rules Engine 2015-10-19 10:53:53 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Sandro Bonazzola 2016-05-02 09:50:07 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 9 Gonza 2016-07-01 10:26:44 UTC
Verified with:
ovirt-engine-4.1.0-0.0.master.20160620231314.git0453503.el7.centos.noarch

...
------------------------------------------------------------------------------
Please note:

The engine database was backed up at 2016-07-01 10:08:21.000000000 +0200 .

Objects that were added, removed or changed after this date, such as virtual
machines, disks, etc., are missing in the engine, and will probably require
recovery or recreation.
------------------------------------------------------------------------------
...

Comment 10 Sandro Bonazzola 2016-07-05 07:41:10 UTC
oVirt 4.0.0 has been released, closing current release.