Bug 1218723

Summary: Trove configuration files set different control_exchange for taskmanager/conductor and api
Product: [Community] RDO Reporter: Javier Peña <jpena>
Component: openstack-troveAssignee: Victoria Martinez de la Cruz <vimartin>
Status: CLOSED CURRENTRELEASE QA Contact: Luigi Toscano <ltoscano>
Severity: high Docs Contact:
Priority: unspecified    
Version: trunkCC: apevec, apevec, hguemar, ltoscano, markmc, sgotliv, vimartin
Target Milestone: ---Keywords: Reopened
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-trove-5.0.0-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-12 16:16:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Javier Peña 2015-05-05 16:55:53 UTC
Description of problem:
The default configuration included with the trove-* packages sets different values for control_exchange. For taskmanager and conductor it is:

control_exchange = trove

For api it is:

#control_exchange = trove

This makes the control_exchange for api be "openstack", causing inability to contact the other processes via rabbitmq.

Version-Release number of selected component (if applicable):

From the RDO Kilo testing repo:

openstack-trove-common-2015.1.0-1.el7
openstack-trove-conductor-2015.1.0-1.el7
openstack-trove-taskmanager-2015.1.0-1.el7

How reproducible:
Always

Steps to Reproduce:
1. Install openstack-trove-* from the Kilo testing repo
2. Set debug=true in trove.conf, trove-taskmanager.conf, trove-conductor.conf
3. Start Trove services

Actual results:
When checking the logs, we will see trove-api using control_exchange=openstack, instead of control_exchange=trove. It will be unable to contact the other services.

Expected results:
Consistent configuration among the Trove services.

Additional info:

Comment 1 Alan Pevec 2015-05-06 08:35:20 UTC
TODO create RDO/openstack-trove BZ component...

Comment 2 Alan Pevec (Fedora) 2015-05-08 18:20:32 UTC
Looks like something which should be fixed before RDO Kilo GA?

Comment 3 Sergey Gotliv 2015-05-10 07:18:29 UTC
I guess that problem doesn't exist in Kilo. Trove configuration is taken from the source conf.sample files:

/etc/trove/trove.conf.sample
/etc/trove/trove-taskmanager.conf.sample
/etc/trove/trove-conductor.conf.sample
/etc/trove/trove-guesagent.conf.sample

In Kilo they all has the same value for control_exchange configuration parameter:

control_exchange = trove

Comment 4 Javier Peña 2015-05-11 10:16:39 UTC
(In reply to Sergey Gotliv from comment #3)
> I guess that problem doesn't exist in Kilo. Trove configuration is taken
> from the source conf.sample files:
> 
> /etc/trove/trove.conf.sample
> /etc/trove/trove-taskmanager.conf.sample
> /etc/trove/trove-conductor.conf.sample
> /etc/trove/trove-guesagent.conf.sample
> 
> In Kilo they all has the same value for control_exchange configuration
> parameter:
> 
> control_exchange = trove

It might be a packaging issue, then. The most up to date version in the Kilo testing repo (https://repos.fedorapeople.org/repos/openstack/openstack-kilo/testing/el7/openstack-trove-common-2015.1.0-3.el7.noarch.rpm) still has that line commented out, so it goes for the default control_exchange of "openstack".

Comment 5 Victoria Martinez de la Cruz 2015-05-12 07:39:56 UTC
It's a problem in packaging and it should be fixed before RDO Kilo GA.

Comment 7 Luigi Toscano 2016-03-31 08:51:24 UTC
This was fixed in the available liberty packages (generated from  	openstack-trove-4.0.0-5.el7.src.rpm ) where all the control_exchange = trove lines are uncommented.
But it regressed in the last Mitaka version, both the RC1 available on cbs.centos (openstack-trove-5.0.0-0.1.0rc1.el7.src.rpm ) and the current DLRN package (seen on openstack-trove-5.0.0.0-0.20160331001539.48a4004.el7.centos.src.rpm). In both cases the line is again commented in the trove.conf shipped with openstack-trove-common, defaulting to "openstack" as defined in oslo.messaging. The line is correctly uncommented in -taskmanager and -conductor.

Comment 8 hguemar 2016-04-12 15:49:05 UTC
Should be fixed in latest RDO Mitaka GA build for Trove, Alan did sync changes from liberty to mitaka branch.
https://github.com/openstack-packages/trove/tree/mitaka-rdo
http://cbs.centos.org/koji/buildinfo?buildID=10429