Bug 1218786

Summary:	UI: VM Explorer: Pressing cancel button on Reconfigure VM or Manage Policies screen does not re-enable the tree.
Product:	Red Hat CloudForms Management Engine	Reporter:	Harpreet Kataria <hkataria>
Component:	UI - OPS	Assignee:	Harpreet Kataria <hkataria>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	5.4.0	CC:	dclarizi, hkataria, jhardy, mfalesni, mpovolny, obarenbo
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 13:01:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Harpreet Kataria 2015-05-05 21:16:55 UTC

Description of problem: VM Explorer: Pressing cancel button on Reconfigure VM or Manage Policies screen does not re-enable the tree


Version-Release number of selected component (if applicable):


How reproducible:100%


Steps to Reproduce:
1. Go to Infrastructure/Virtual Machines explorer
2. Click to view a VM
3. Press Reconfigure this VM or Manage Policies button, then press Cancel button in the form. Tree remains disabled

Actual results:
Tree remain disabled after pressing cancel button

Expected results:
After cancel button is pressed Tree should re-enable

Additional info:
Looks like fix in https://github.com/ManageIQ/manageiq/pull/2796 has caused this issue. This code in explorer presenter seems to be the culprit https://github.com/ManageIQ/manageiq/blob/master/vmdb/app/presenters/explorer_presenter.rb#L163

Comment 2 CFME Bot 2015-05-06 20:40:54 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c82b2de54e904aa478521da9713be9f45f018cec

commit c82b2de54e904aa478521da9713be9f45f018cec
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue May 5 17:20:52 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue May 5 17:20:52 2015 -0400

    Added curly braces in the if block.
    
    Only unload/initialize toolbar when tb is present in miq_toolbars, need to add braces around statements if block.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1218786

 vmdb/app/helpers/application_helper.rb | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Comment 3 Milan Falešník 2015-05-12 11:48:34 UTC

Verified in 5.4.0.0.26, tree is re-enabled in both those cases.

Comment 6 errata-xmlrpc 2015-06-16 13:01:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html