Bug 1218854

Summary:	Clean up should not empty the contents of the global config file
Product:	[Community] GlusterFS	Reporter:	Meghana <mmadhusu>
Component:	ganesha-nfs	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	kkeithle, vagarwal
Target Milestone:	---	Keywords:	EasyFix, Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1218857 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:59:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1218857

Description Meghana 2015-05-06 04:13:23 UTC

Description of problem:
The global config file will need new blocks to support client lock recovery.
Current cleanup function empties the entire file. Deleting only "include"
lines in the config file.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-05-06 04:30:47 UTC

REVIEW: http://review.gluster.org/10592 (NFS-Ganesha : Do not empty global config file when cluster is torn) posted (#1) for review on master by Meghana M (mmadhusu)

Comment 2 Anand Avati 2015-05-06 12:35:19 UTC

COMMIT: http://review.gluster.org/10592 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit e79edf35178f2558d6afb262444294380b76d740
Author: Meghana Madhusudhan <mmadhusu>
Date:   Wed May 6 09:58:11 2015 +0530

    NFS-Ganesha : Do not empty global config file when cluster is torn
    
    The global config file will need new blocks to support client lock recovery.
    Current cleanup function empties the entire file. Deleting only "include"
    lines in the config file.
    
    Change-Id: I21f09e30a738d2ba01861ce480ecf906667d887b
    BUG: 1218854
    Signed-off-by: Meghana Madhusudhan <mmadhusu>
    Reviewed-on: http://review.gluster.org/10592
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Anand Avati 2015-05-07 15:37:58 UTC

COMMIT: http://review.gluster.org/10630 committed in master by Niels de Vos (ndevos) 
------
commit 7f950ed3ae4f99542ba4bbabec5fc1a86850a528
Author: Meghana Madhusudhan <mmadhusu>
Date:   Thu May 7 15:34:06 2015 +0530

    NFS-Ganesha : Improved sed expression in cleanup
    
    The global config file should not be emptied when
    tear down is called. Improving the sed expression
    to delete the ".conf" files only
    Signed-off-by: Meghana Madhusudhan <mmadhusu>
    
    Change-Id: Ida3d303f629cb512c02dadacce1ec7e5f07db018
    BUG: 1218854
    Reviewed-on: http://review.gluster.org/10630
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: soumya k <skoduri>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Nagaprasad Sathyanarayana 2015-10-25 15:06:55 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 7 Niels de Vos 2016-06-16 12:59:05 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user