Bug 1219396

Summary: Disk permissions are never loaded in webadmin
Product: [Retired] oVirt Reporter: Ondra Machacek <omachace>
Component: ovirt-engine-webadminAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Ondra Machacek <omachace>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.6CC: amureini, bugs, ecohen, gklein, lsurette, mgoldboi, omachace, rbalakri, tnisan, yeylon
Target Milestone: ---   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ux
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-04 11:49:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ondra Machacek 2015-05-07 08:48:45 UTC
Description of problem:


Version-Release number of selected component (if applicable):
rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch

How reproducible:
always

Steps to Reproduce:
1. Create disk.
2. Go to disk permissions subtab.

Actual results:
Waiting animation forever.

Expected results:
Disk's permissions shown.

Additional info:

Comment 1 Einav Cohen 2015-05-08 15:16:25 UTC
I reproduced on ~latest 'master' as well. 

I couldn't find a client (javascript) exception or a server-side exception, but maybe I missed something. 

This seems to happen only in Disks, therefore I marked the Whiteboard as 'storage', however feel free to change it to infra(?)/sla(?)/whoever is in charge on permissions, if makes sense to do so.

Comment 2 Allon Mureinik 2015-05-10 07:44:52 UTC
Confirmed all of Einav's conclusions on master built from source from commit hash 4f159434494ec020b4d23c96b499a4207ef7c18f.

Tal, please have someone look into this?

Comment 3 Tal Nisan 2015-05-10 10:24:16 UTC
Been investigating this issue and indeed there is no client side exception or something that seems that can cause this error, however, the permission model is unified for all entities in the system and after debugging back and forth it seems that the permissions query is correctly sent to the backend and a correct result is returned to the frontend callback yet the animation is not turned off hence it feels to me like a more ui-infra problem since there is nothing storage specific about it.
Einav, can someone from your team have a look please? I can't seem to find the root cause of the problem

Comment 4 Einav Cohen 2015-05-11 12:55:06 UTC
targeted for 3.5, since this is a regression.

Comment 5 Ondra Machacek 2015-05-11 13:03:03 UTC
does not happen on 3.5 (at least for me)

Comment 6 Einav Cohen 2015-05-11 13:09:14 UTC
(In reply to Ondra Machacek from comment #5)
> does not happen on 3.5 (at least for me)

Ondre, didn't you report this issue on rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch?

[Note that by "3.5" I don't mean "3.5.0" - I mean "3.5.x" in general; i.e. fixing patch needs to be backported to the 'ovirt-engine-3.5' branch of the oVirt code repository]

Comment 7 Ondra Machacek 2015-05-11 13:23:56 UTC
Oh sorry, I see I wrote "rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch", but
I hit this issue only on 3.6, not on any 3.5.x version. That's why I've opened
it for version 3.6, but then probably copied version of different installation,
sorry.

Works fine for "rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch".

Comment 8 Einav Cohen 2015-05-11 13:44:21 UTC
(In reply to Ondra Machacek from comment #7)
> Oh sorry, I see I wrote "rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch", but
> I hit this issue only on 3.6, not on any 3.5.x version. That's why I've
> opened
> it for version 3.6, but then probably copied version of different
> installation,
> sorry.

that's ok - many thanks for the clarification, Ondra. 
re-targeting the BZ accordingly. 

> 
> Works fine for "rhevm-webadmin-portal-3.5.1-0.3.el6ev.noarch".

also removing the 'Regression' keyword, as it seems to be working ok in the previous version (3.5).

Comment 9 Max Kovgan 2015-06-28 14:13:54 UTC
ovirt-3.6.0-3 release

Comment 10 Ondra Machacek 2015-06-29 08:17:24 UTC
OK in 3.6.0-3

Comment 11 Sandro Bonazzola 2015-11-04 11:49:04 UTC
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.