Bug 1219479

Summary:	[Dist-geo-rep] after snapshot in geo-rep setup, empty changelogs are generated in the snapped brick.
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	medium
Version:	3.7.0	CC:	aavati, avishwan, bugs, csaba, david.macdonald, gluster-bugs, nlevinki, rhs-bugs, sarumuga, storage-qa-internal, vkoppad
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	consistency
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1208470	Environment:
Last Closed:	2016-06-16 12:59:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1127581, 1208470
Bug Blocks:

Description Kotresh HR 2015-05-07 12:53:49 UTC

+++ This bug was initially created as a clone of Bug #1208470 +++

+++ This bug was initially created as a clone of Bug #1127581 +++

Description of problem: Once snapshot is taken in a geo-rep setup, the empty changelogs are generated in the snapped brick.

===============================================================================
# ls /bricks/brick1/master_b1/.glusterfs/changelogs/ | wc -l
64
[root@targarean geo-rep-auto-logs]# ls /var/run/gluster/snaps/e2fb7c79994044678fba65ae14ecaada/brick1/master_b1/.glusterfs/changelogs/ | wc -l
65
===============================================================================

first one is live brick and second one is snapped brick

Version-Release number of selected component (if applicable):

How reproducible: Happens everytime


Steps to Reproduce:
1. create and start a geo-rep relationship between master and slave.
2. start creating data and parallely create snapshot(follow steps to create snapshot in geo-rep setup)
3. after the snapshot check the number of changelogs in snapped brick.


Actual results:  empty changelogs are  generated in the snapped brick.


Expected results: it shouldn't keep generating empty changelogs in snapped brick.

Comment 1 Anand Avati 2015-05-07 12:56:56 UTC

REVIEW: http://review.gluster.org/10642 (features/changelog: Avoid creation of empty changelogs) posted (#1) for review on release-3.7 by Kotresh HR (khiremat)

Comment 2 Anand Avati 2015-05-08 06:26:03 UTC

REVIEW: http://review.gluster.org/10642 (features/changelog: Avoid creation of empty changelogs) posted (#2) for review on release-3.7 by Kotresh HR (khiremat)

Comment 3 Anand Avati 2015-05-08 13:14:18 UTC

COMMIT: http://review.gluster.org/10642 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 1b42cb507c3f72225f03a4715e051d9eb8c08e43
Author: Saravanakumar Arumugam <sarumuga>
Date:   Wed Apr 29 17:33:43 2015 +0530

    features/changelog: Avoid creation of empty changelogs
    
    An empty changelog when rolled over gets unlinked and indexed with
    a modified path-name in htime file. The modification is "changelog"
    not "CHANGELOG" in basename of the empty changelog file.
    
    BUG: 1219479
    Change-Id: Ib5b825ab563fa34d8dcf4368cf6cbf4b25d78a6d
    Original-Author: Ajeet Jha <ajha>
    Original-Author: Saravanakumar Arumugam <sarumuga>
    Reviewed-On: http://review.gluster.org/#/c/9572/
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/10642
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Aravinda VK <avishwan>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2015-05-08 15:11:02 UTC

REVIEW: http://review.gluster.org/10685 (features/changelog: Fixing compilation issue) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 5 Anand Avati 2015-05-08 15:18:33 UTC

COMMIT: http://review.gluster.org/10685 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit aceecc2285ab3e5d3150f0d8c644371213c61b65
Author: Aravinda VK <avishwan>
Date:   Fri May 8 20:38:33 2015 +0530

    features/changelog: Fixing compilation issue
    
    This issue introduced due to manual rebase.
    
    Change-Id: I0589f4a0a1270190340f419b8022d6483bcf853d
    Signed-off-by: Aravinda VK <avishwan>
    BUG: 1219479
    Reviewed-on: http://review.gluster.org/10685
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Niels de Vos <ndevos>

Comment 6 Anand Avati 2015-05-08 15:27:25 UTC

REVIEW: http://review.gluster.org/10686 (features/changelog: Fixing compilation issue) posted (#1) for review on release-3.7 by Aravinda VK (avishwan)

Comment 7 Anand Avati 2015-05-08 15:38:09 UTC

COMMIT: http://review.gluster.org/10686 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 004e34ffcaa7a53348479488b0716979f8a958df
Author: Aravinda VK <avishwan>
Date:   Fri May 8 20:38:33 2015 +0530

    features/changelog: Fixing compilation issue
    
    This issue introduced due to manual rebase.
    
    Change-Id: I0589f4a0a1270190340f419b8022d6483bcf853d
    Signed-off-by: Aravinda VK <avishwan>
    BUG: 1219479
    Reviewed-on: http://review.gluster.org/10685
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/10686

Comment 8 Niels de Vos 2015-05-14 17:27:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:28:57 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:35:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2016-06-16 12:59:05 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user