Bug 1219784

Summary:	bitrot: glusterd is crashing when user enable bitrot on the volume
Product:	[Community] GlusterFS	Reporter:	Gaurav Kumar Garg <ggarg>
Component:	bitrot	Assignee:	Satish Mohan <smohan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	mainline	CC:	bugs, smohan
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1219785 (view as bug list)		Environment:
Last Closed:	2016-06-16 12:59:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1219785

Description Gaurav Kumar Garg 2015-05-08 09:09:19 UTC

Description of problem:

glusterd is crashing when user enable bitrot on the volume.


Version-Release number of selected component (if applicable):


How reproducible:
always


Steps to Reproduce:
1. create a cluster of two node.
2. create plane distribute volume which is having brick only in first node.
3. start the volume form any node.
4. enable bitrot form second node which is not having any brick.

glusterd will crash.

Actual results:

glusterd is crashing.


Expected results:

glusterd should not crash.


Additional info:

Comment 1 Anand Avati 2015-05-08 13:59:50 UTC

REVIEW: http://review.gluster.org/10680 (bitrot: Volfile generation should not proceed if node don't have any brick.) posted (#1) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-05-09 09:25:18 UTC

REVIEW: http://review.gluster.org/10664 (bitrot: Volfile generation should not proceed if node doesn't have any brick.) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-05-09 13:45:44 UTC

REVIEW: http://review.gluster.org/10664 (bitrot: Volfile generation should not proceed if node doesn't have any brick.) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2015-05-09 17:35:15 UTC

REVIEW: http://review.gluster.org/10664 (bitrot: Volfile generation should not proceed if node doesn't have any brick.) posted (#4) for review on master by Vijay Bellur (vbellur)

Comment 5 Anand Avati 2015-05-10 05:25:38 UTC

COMMIT: http://review.gluster.org/10664 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 3586581c6edf222daf836c99ce2a1a266dc741f8
Author: Gaurav Kumar Garg <ggarg>
Date:   Fri May 8 13:08:22 2015 +0530

    bitrot: Volfile generation should not proceed if node doesn't have any brick.
    
    glusterd crashes when bitrot is enabled on a distributed volume from a node
    which doesn't host a brick.
    
    While generating volfile glusterd should check number of brick on that node. If
    node doesn't have any brick then graph generation for bitrot and scrubber should
    not proceed further.
    
    Change-Id: I2158113e20e93738cde2a22fd73f0ae6b22aae9e
    BUG: 1219784
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10664
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 6 Nagaprasad Sathyanarayana 2015-10-25 14:55:02 UTC

Fix for this bug is already made in a GlusterFS release. The cloned BZ has details of the fix and the release. Hence closing this mainline BZ.

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:59:58 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 10 Niels de Vos 2016-06-16 12:59:33 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user