Bug 1219785

Summary:	bitrot: glusterd is crashing when user enable bitrot on the volume
Product:	[Community] GlusterFS	Reporter:	Gaurav Kumar Garg <ggarg>
Component:	bitrot	Assignee:	Gaurav Kumar Garg <ggarg>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:	bugs <bugs>
Priority:	high
Version:	3.7.0	CC:	bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1219784	Environment:
Last Closed:	2015-05-14 17:29:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1219784
Bug Blocks:	1199352

Description Gaurav Kumar Garg 2015-05-08 09:10:31 UTC

+++ This bug was initially created as a clone of Bug #1219784 +++

Description of problem:

glusterd is crashing when user enable bitrot on the volume.


Version-Release number of selected component (if applicable):


How reproducible:
always


Steps to Reproduce:
1. create a cluster of two node.
2. create plane distribute volume which is having brick only in first node.
3. start the volume form any node.
4. enable bitrot form second node which is not having any brick.

glusterd will crash.

Actual results:

glusterd is crashing.


Expected results:

glusterd should not crash.


Additional info:

Comment 1 Anand Avati 2015-05-09 13:56:59 UTC

REVIEW: http://review.gluster.org/10680 (bitrot: Volfile generation should not proceed if node doesn't have any brick.) posted (#3) for review on release-3.7 by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-05-09 17:48:05 UTC

REVIEW: http://review.gluster.org/10680 (bitrot: Volfile generation should not proceed if node doesn't have any brick.) posted (#4) for review on release-3.7 by Vijay Bellur (vbellur)

Comment 3 Anand Avati 2015-05-10 08:56:50 UTC

COMMIT: http://review.gluster.org/10680 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 0d7a64e68cadd61ae774200fae47886cdc004c87
Author: Gaurav Kumar Garg <ggarg>
Date:   Fri May 8 13:08:22 2015 +0530

    bitrot: Volfile generation should not proceed if node doesn't have any brick.
    
    glusterd crashes when bitrot is enabled on a distributed volume from a node
    which doesn't host a brick.
    
    While generating volfile glusterd should check number of brick on that node. If
    node doesn't have any brick then graph generation for bitrot and scrubber should
    not proceed further.
    
    Change-Id: I2158113e20e93738cde2a22fd73f0ae6b22aae9e
    BUG: 1219785
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/10680
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2015-05-14 17:29:39 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:36:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:47:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user