Bug 1220070
Summary: | horizon requires manage.py compress to be run | ||
---|---|---|---|
Product: | [Community] RDO | Reporter: | Harm Weites <harm> |
Component: | openstack-horizon | Assignee: | Matthias Runge <mrunge> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | wes hayutin <whayutin> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | Kilo | CC: | harm, justin.t.riley, mrunge |
Target Milestone: | --- | ||
Target Release: | Kilo | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-09-10 07:34:47 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Harm Weites
2015-05-09 19:10:22 UTC
How are you installing horizon? plain packages, packstack? I would expect this to be fixed with latest package. yum update && systemctl restart httpd I'm installing using plain packages from delorean-kilo (specifically: this is with the Kolla project), I'll check if those were updated within the last days. Is this a known and even fixed issue? I suspect this to be a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1219006 There was a systemd macro added some time ago, which runs ./manage.py collectstatic && ./manage.py compress during httpd start Did you restart httpd after installing or updating the package? Ah, well Kolla isn't using systemd for obvious reasons :) Shouldn't that step be in %post anyway or is there a reason to do it at launchtime? A httpd restart is required anyways, when adding horizon, it makes sense to couple that to httpd. This is run on each httpd restart. Updating javascript libs etc. would require manage.py collectstatic and manage.py compress to be executed manually, if we remove that systemd snippet. That's another pro to move that step from %post to external. The question is more: do we want to add that collect and compress step to %post, too? It has never been there (it was executed at package build time). If it used to be at %build, which is in the package, I'd +1 for moving it back into the package again and perhaps even put it in both places. Perhaps we can eval() the ExecPre from %post, to keep systemd happy? That way Kolla (which doesn't use systemd, since we're all-in Docker) can happily install this package with the same outcome as regular RDO users. This is installed as /usr/lib/systemd/system/httpd.service.d/openstack-dashboard.conf: [Service] ExecStartPre=/usr/bin/python /usr/share/openstack-dashboard/manage.py collectstatic --noinput --clear ExecStartPre=/usr/bin/python /usr/share/openstack-dashboard/manage.py compress --force Sorry for late feedback here. I put this back to packages http://pkgs.fedoraproject.org/cgit/python-django-horizon.git/commit/?h=f23& id=d3d389d40998768df971275a92b0b9ca5de6d92b and it should be fixed in each package built after June 2015. |