Bug 1220770

Summary: Review Request: vim-fugitive - A Git wrapper so awesome, it should be illegal
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Bohuslav "Slavek" Kabrda <bkabrda>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bkabrda, marc, package-review
Target Milestone: ---Flags: bkabrda: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: vim-fugitive-2.2-2.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-13 15:39:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vít Ondruch 2015-05-12 11:45:29 UTC 
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/vim-fugitive.git/tree/vim-fugitive.spec?id=ffe4f95c4f3707288ba1c893c050e3f6c201b17e
SRPM URL: http://people.redhat.com/vondruch/vim-fugitive-2.2-1.fc23.src.rpm
Description: fugitive.vim may very well be the best Git wrapper of all time. Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9711450
Comment 1 Vít Ondruch 2015-05-12 11:57:14 UTC 
Forgot to run rpmlint and it revealed some issues indeed.


Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/vim-fugitive.git/tree/vim-fugitive.spec?id=15858d8b3e5eca7c29af4c6fb54d65d6b06e9e12
SRPM URL: http://people.redhat.com/vondruch/vim-fugitive-2.2-2.fc23.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9711686
Comment 2 Bohuslav "Slavek" Kabrda 2015-05-12 12:07:16 UTC 
Taking this.
Comment 3 Bohuslav "Slavek" Kabrda 2015-05-12 12:38:01 UTC 
- rpmlint output is OK (it only gives a couple of spelling error warnings which actually are false positives)
- licensing is fine
- everything else including %post and %postun scriptlets also seems to be fine, package builds cleanly in mock

I can't find a single problem with this package, therefore it is APPROVED.
Comment 4 Vít Ondruch 2015-05-13 08:23:39 UTC 
Appreciate your swift review. Trying request new package in pkgdb [1], lets see how it works :)


https://admin.fedoraproject.org/pkgdb/package/requests/119
Comment 5 Kamil Dudka 2015-07-01 12:41:00 UTC 
*** Bug 1236403 has been marked as a duplicate of this bug. ***