Bug 1221149
| Summary: | SmartState fails to show UTF-8 encoded files | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Christian Jung <cbolz> | ||||||||||
| Component: | SmartState Analysis | Assignee: | Milan Zázrivec <mzazrivec> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Ramesh A <rananda> | ||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | 5.3.0 | CC: | cpelland, dajohnso, dclarizi, gblomqui, hkataria, jfrey, jhardy, jprause, mcornea, mpovolny, obarenbo | ||||||||||
| Target Milestone: | GA | Keywords: | ZStream | ||||||||||
| Target Release: | 5.5.3 | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | retest:smartstate | ||||||||||||
| Fixed In Version: | 5.5.3.2 | Doc Type: | Bug Fix | ||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | |||||||||||||
| : | 1289329 (view as bug list) | Environment: | |||||||||||
| Last Closed: | 2016-04-13 18:39:08 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 1289329 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Christian Jung
2015-05-13 11:39:55 UTC
Created attachment 1025020 [details]
mrt.log which causes the error
In summary, UTF-16 file contents can't be shown in the UI and give an error about UTF8 conversion. Christian, we have changed the logic around displaying these files in upstream. As the target release is now 5.5, the upstream code is, what is relevant now. Can you, please, verify that this bug is present in upstream? Thx! HiHo, I tested this again today with Botvinik. Botvinik falsely reports all files as being binary and unable to view. Even files which were shown fine with 5.3 are now reported as being binary (which is not correct). Regards, Christian Created attachment 1071051 [details]
wlms incorrectly reported as being binary
Created attachment 1071053 [details]
mrt.log incorrectly reported as bein binary
So we have 2 options here I'd say 1) try to do someting smart like guess the encoding, try to convert the file to utf8 to display it 2) offer a download link for files that we cannot display I don't think that 1) is a case for a simple fix. Would 2) work for you? New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/56f5ac2c74f1550d7af9d8e68ec9e87f287d34d1 commit 56f5ac2c74f1550d7af9d8e68ec9e87f287d34d1 Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Nov 23 17:30:56 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Mon Nov 23 18:18:05 2015 +0100 Add download link for filesystem data https://bugzilla.redhat.com/show_bug.cgi?id=1221149 app/controllers/vm_common.rb | 5 +++++ app/views/layouts/_item.html.haml | 2 ++ config/routes.rb | 2 ++ spec/factories/miq_report.rb | 11 +++++++++++ spec/routing/vm_cloud_routing_spec.rb | 6 ++++++ spec/routing/vm_infra_routing_spec.rb | 6 ++++++ spec/views/layouts/_item.html.haml_spec.rb | 22 ++++++++++++++++++++++ 7 files changed, 54 insertions(+) create mode 100644 spec/views/layouts/_item.html.haml_spec.rb *** Bug 1222508 has been marked as a duplicate of this bug. *** New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f9a50ec9c42b721af115d107c49c2a190b5609f5 commit f9a50ec9c42b721af115d107c49c2a190b5609f5 Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Nov 23 17:30:56 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Nov 24 13:30:19 2015 +0100 Add download link for filesystem data https://bugzilla.redhat.com/show_bug.cgi?id=1221149 (cherry picked from commit 56f5ac2c74f1550d7af9d8e68ec9e87f287d34d1) app/controllers/vm_common.rb | 5 +++++ app/views/layouts/_item.html.haml | 2 ++ config/routes.rb | 2 ++ spec/factories/miq_report.rb | 11 +++++++++++ spec/routing/vm_cloud_routing_spec.rb | 6 ++++++ spec/routing/vm_infra_routing_spec.rb | 6 ++++++ spec/views/layouts/_item.html.haml_spec.rb | 22 ++++++++++++++++++++++ 7 files changed, 54 insertions(+) create mode 100644 spec/views/layouts/_item.html.haml_spec.rb New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=6077f611821d0ebd8c7a15234546747d6d6d74ed commit 6077f611821d0ebd8c7a15234546747d6d6d74ed Merge: 539830f f9a50ec Author: Dan Clarizio <dclarizi> AuthorDate: Mon Dec 7 17:40:00 2015 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Mon Dec 7 17:40:00 2015 -0500 Merge branch 'filesystem_download_link' into '5.5.z' Add download link for filesystem data https://bugzilla.redhat.com/show_bug.cgi?id=1221149 Clean cherry pick from commit 56f5ac2c74f1550d7af9d8e68ec9e87f287d34d1 See merge request !529 app/controllers/vm_common.rb | 5 +++++ app/views/layouts/_item.html.haml | 2 ++ config/routes.rb | 2 ++ spec/factories/miq_report.rb | 11 +++++++++++ spec/routing/vm_cloud_routing_spec.rb | 6 ++++++ spec/routing/vm_infra_routing_spec.rb | 6 ++++++ spec/views/layouts/_item.html.haml_spec.rb | 22 ++++++++++++++++++++++ 7 files changed, 54 insertions(+) Forgot to mention, it happens only for mrt.log. For other logs - passwd.log, sammui.log, download button is available. Created attachment 1116628 [details]
UTF Error
Verified in 5.5.2.1.20160114044944_395c086 New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d062d845f43351b57cee6c124866407ab7f53bdb commit d062d845f43351b57cee6c124866407ab7f53bdb Author: Milan Zazrivec <mzazrivec> AuthorDate: Thu Jan 21 15:26:10 2016 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Jan 26 11:48:48 2016 +0100 Fix rendering of UTF-16 blobs by conversion to UTF-8 https://bugzilla.redhat.com/show_bug.cgi?id=1221149 (cherry picked from commit 1cf749c1942840e2dd1331a8b71fa0c826fb1162) app/helpers/ui_constants.rb | 3 +++ app/models/filesystem.rb | 10 ++++++++++ app/views/layouts/_item.html.haml | 2 +- spec/models/filesystem_spec.rb | 19 +++++++++++++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a984ddac1a4866e282ef2b79090faa5d354b4fd8 commit a984ddac1a4866e282ef2b79090faa5d354b4fd8 Merge: b5b0670 d062d84 Author: Dan Clarizio <dclarizi> AuthorDate: Wed Feb 10 13:44:17 2016 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Wed Feb 10 13:44:17 2016 -0500 Merge branch 'fix_displaying_of_utf16_blobs' into '5.5.z' Fix rendering of UTF-16 blobs by conversion to UTF-8 https://bugzilla.redhat.com/show_bug.cgi?id=1221149 (cleanly cherry picked from commit 1cf749c1942840e2dd1331a8b71fa0c826fb1162) See merge request !748 app/helpers/ui_constants.rb | 3 +++ app/models/filesystem.rb | 10 ++++++++++ app/views/layouts/_item.html.haml | 2 +- spec/models/filesystem_spec.rb | 19 +++++++++++++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) Good to go. Verified and working fine in 5.5.3.2.20160318152106_92d2d67. Now CFME appliance displays the mrt.log file contents and download button is also available. Clicking on the download button, downloads the file correctly. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:0616 Test case added : RHCF3-11385 - test_ssa_files[windows-utf-8-files] |