Bug 122145
| Summary: | Logrotate does not allow non-ASCII paths | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Göran Uddeborg <goeran> | ||||||
| Component: | logrotate | Assignee: | Peter Vrabec <pvrabec> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 6 | CC: | baris, fedora-ja-list | ||||||
| Target Milestone: | --- | Keywords: | i18n | ||||||
| Target Release: | --- | ||||||||
| Hardware: | i386 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-01-09 10:05:48 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
[This is a mass update sent to many bugs that missed earlier such messages due to having their version set to a test version.] This bug was originally filed against a version of Fedora Core which is no longer supported, even for security updates. Many changes have occured since then. Please retest this bug against a still supported version. Note that FC3 and FC4 are supported by Fedora Legacy for security fixes only. If it still occurs on FC5 or FC6, please assign to the correct version. Otherwise, if this a security issue, please change the product to Fedora Legacy. Thanks, and we are sorry that we did not get to this bug earlier. This bug will be closed after a few weeks if no information is given indicating that the bug is still present in a supported release. This problem still remains in logrotate-3.7.4-7 of FC6. Created attachment 144952 [details]
This patch checks characters using widechar equivalent of isprint
This patch is checking directory names using iswprint, instead of isprint.
Tested with directories that have widechar in it, and my tests show it works
with FC6.
(In reply to comment #3) > Created an attachment (id=144952) [edit] > This patch checks characters using widechar equivalent of isprint I'm sorry I don't think this is a proper usage of iswprint() Created attachment 145056 [details]
could you test this please
It looks alright. fixed in logrotate-3.7.4-9.fc{6,7}
|
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040312 Description of problem: The file config.c contains a little comment: /* this is technically too restrictive -- let's see if anyone complains */ while (*chptr && isprint(*chptr) && *chptr != ' ') chptr++; Well, here I am! :-) The path I want to use is to my home directory. The characters are all printable *in my locale*. But logrotate doesn't do any setlocale() call, and thus only accepts ASCII. Version-Release number of selected component (if applicable): logrotate-3.7-4.1 How reproducible: Always Steps to Reproduce: 1. Create a logrotate configuration file: /tmp/apa { olddir /tmp/göran } (In case bugzilla mangles it: I used my name for the directory name, and it has o-diaeresis as its second character.) 2. touch /tmp/apa 3. mkdir /tmp/göran 4. logrotate -s status config Actual Results: error: config:2 bad olddir path /tmp/göran Expected Results: Rotation of /tmp/apa Additional info: The easy part is adding "#include <locale.h>" at the top and "setlocale(LC_ALL, "")" just at the beginning of main in logrotate.c. Then of course the loop in config.c has to be redone to take multibyte characters into consideration.