Bug 1221474

Spec URL: https://gil.fedorapeople.org/rrd4j.spec
SRPM URL: https://gil.fedorapeople.org/rrd4j-2.2.1-1.fc22.src.rpm

Spec URL: https://gil.fedorapeople.org/rrd4j.spec
SRPM URL: https://gil.fedorapeople.org/rrd4j-2.2.1-1.fc23.src.rpm

gil's scratch build of rrd4j-2.2.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12051015

Hello,

If you're still willing to package this:
 
 - Update the SPEC to version 3.2

→ New BR for this:

BuildRequires: mvn(com.sleepycat:je)
BuildRequires: mvn(junit:junit)
BuildRequires: mvn(org.mongodb:mongo-java-driver)
BuildRequires: mvn(org.mongodb:mongodb-driver)
BuildRequires: mvn(org.sonatype.oss:oss-parent:pom:)
BuildRequires: mvn(org.easymock:easymock)
BuildRequires: mvn(org.jacoco:jacoco-maven-plugin)

→ Remove:

%pom_change_dep :mongo-java-driver ::2

→ Updated patch for the fonts:

diff -up rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java.use-system-fonts rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java
--- rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java.use-system-fonts	2017-11-11 13:33:45.000000000 +0100
+++ rrd4j-3.2/src/main/java/org/rrd4j/graph/RrdGraphConstants.java	2017-11-29 00:02:05.325110896 +0100
@@ -1,6 +1,8 @@
 package org.rrd4j.graph;
 
 import java.awt.*;
+import java.io.BufferedInputStream;
+import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Calendar;
@@ -272,13 +274,22 @@ public interface RrdGraphConstants {
          * @return a new {@link java.awt.Font} instance
          */
         public static Font getFont(int type, int size) {
+
+            InputStream fontstream = null;
+
             String fontPath;
+
             if (type == Font.BOLD)
-                fontPath = "/DejaVuSansMono-Bold.ttf";
+                fontPath = "/usr/share/fonts/dejavu/DejaVuSansMono-Bold.ttf";
             else
-                fontPath = "/DejaVuSansMono.ttf";
+                fontPath = "/usr/share/fonts/dejavu/DejaVuSansMono.ttf";
 
-            InputStream fontstream = RrdGraphConstants.class.getResourceAsStream(fontPath);
+            try {
+                fontstream = new BufferedInputStream(new FileInputStream(fontPath));
+            } catch (Exception ex) {
+                ex.printStackTrace();
+                System.err.println("Font not loaded.");
+            }
             try {
                 return Font.createFont(Font.TRUETYPE_FONT, fontstream).deriveFont(type == Font.BOLD ? Font.BOLD : Font.PLAIN, size);
             } catch (FontFormatException e) {


→ Changelog:

* Tue Nov 28 2017 Gil Cattaneo <puntogil> 3.2-1
- update to 3.2


 - Use a more meaningful name for your archive, with:

Source0:       https://github.com/rrd4j/rrd4j/archive/%{version}/%{name}-%{version}.tar.gz

 - Not needed:

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

I think that a 
+                ex.printStackTrace();
+                System.err.println("Font not loaded.");
 in a library is never a good idea.

I would rather wrap the Exception in a RuntimeException.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.