Bug 1221810

Summary: FindRuby.cmake is broken (cannot find Ruby 2.2)
Product: [Fedora] Fedora Reporter: Michael Catanzaro <mcatanzaro+wrong-account-do-not-cc>
Component: cmakeAssignee: Orion Poplawski <orion>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 22CC: helio, jreznik, ltinkl, orion, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 21:30:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Catanzaro 2015-05-14 21:17:30 UTC 
Hm, I think subject says it all here.

I'm fixing this WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=145014

This fix is going to break builds on Fedora 22, because our FindRuby is only capable of finding versions of Ruby up through 2.1. That's bad because Fedora 22 has Ruby 2.2.

Example nonsense error:

Could NOT find Ruby (missing: RUBY_INCLUDE_DIR RUBY_LIBRARY
  RUBY_CONFIG_INCLUDE_DIR) (found suitable version "2.2.0", minimum required
  is "1.8.7")
Comment 1 Michael Catanzaro 2015-05-14 21:30:16 UTC 
Er, it's just a confusing error message, sorry. It's checking for the full ruby-devel package when I just had ruby (the interpreter only) installed. The confusing message combined with a misleading comment at the top of the find module confused me:

# This module finds if Ruby is installed and determines where the
# include files and libraries are.  Ruby 1.8, 1.9, 2.0 and 2.1 are
# supported.

This just means the find module doesn't check for ruby2.2 or ruby22 binaries, not that it magically breaks finding the ruby binary itself. It would be good to fix that I suppose, but it's not the problem I thought it was.