Bug 1221931

Summary:	Move scale app to different profile district node should return 1
Product:	OpenShift Container Platform	Reporter:	Anping Li <anli>
Component:	Node	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	2.2.0	CC:	adellape, jialiu, jokerman, libra-onpremise-devel, mmasters, mmccomas, tiwillia
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-origin-broker-util-1.36.2.1-1.el6op	Doc Type:	Bug Fix
Doc Text:	When the `oo-admin-move` command failed to move a scalable application across districts, previously the exit code returned was 0, as if there was no failure. This bug fix updates the command to properly exit with a non-zero exit code upon failure.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-09-30 16:37:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1214087
Bug Blocks:

Description Anping Li 2015-05-15 09:39:19 UTC

Description of problem:
Openshift doesn't allow to move scale application to different profile node. The gear move command should return error code 1. No such issue in OSE-2.2 2015-04-02. 

Version-Release number of selected component (if applicable):
OSE-2.2 2015-05-11.1

How reproducible:
Always

Steps to Reproduce:
1.Move scale application to  different profile node in district . check the return code "$?"
2.
3.

Actual results:
The return code is 0
[root@broker bin]# oo-admin-move --gear_uuid 5555b42082611d0fe70000ea -i node1.ose22-auto.com.cn
URL: http://sphp-anlidom.ose22-auto.com.cn
Login: anli
App UUID: 5555b42082611d0fe70000ea
Gear UUID: 5555b42082611d0fe70000ea
DEBUG: Source district uuid: 5555b33882611da4e9000001
DEBUG: Destination district uuid: 5555b34082611d7be6000001
Cannot change node_profile for *scalable* application gear - this operation is not supported. The destination container's node profile is medium, while the gear's node_profile is small
Error moving gear. Cannot change node profile for *scalable* app.
[root@broker bin]# echo $?
0

Expected results:
The return code is 1

Additional info:

Comment 1 Miciah Dashiel Butler Masters 2015-09-22 19:29:43 UTC

I believe this defect is fixed with https://github.com/openshift/origin-server/commit/14726cc0f56df96f370fdf00d21555cf34d96789 "Bug 1214087 - return non-zero on all exceptions in oo-admin-move", which should be in openshift-origin-broker-util-1.36.2.1-1.el6op.

Comment 5 Johnny Liu 2015-09-23 05:57:07 UTC

Verified this bug with openshift-origin-broker-util-1.36.2.2-1.el6op.noarch in 2.2/2015-09-22.1, PASS.


[root@broker ~]# oo-admin-move --gear_uuid jialiu-scaphp53app-1 -i broker.ose22-auto.com.cn
URL: http://scaphp53app-jialiu.ose22-auto.com.cn
Login: jialiu
App UUID: 56021d7b82611d78b400004f
Gear UUID: 56021d7b82611d78b400004f
DEBUG: Source district uuid: 5601f7fe82611d9f7b000001
DEBUG: Destination district uuid: 5601f80e82611ddf8c000001
Cannot change node_profile for *scalable* application gear - this operation is not supported. The destination container's node profile is medium, while the gear's node_profile is small
Error moving gear. Cannot change node profile for *scalable* app.

[root@broker ~]# echo $?
1

Comment 7 errata-xmlrpc 2015-09-30 16:37:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1844.html