Bug 1221967

Summary:	Do not allow detach-tier commands on a non tiered volume
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	tiering	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, dlambrig, nchilaka, rkavunga
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	TIERING
Fixed In Version:	glusterfs-3.7.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1221270	Environment:
Last Closed:	2015-06-02 08:02:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1221270, 1226168
Bug Blocks:	1221957, 1229269, 1260923, 1273726, 1274411

Description Niels de Vos 2015-05-15 11:11:03 UTC

+++ This bug was initially created as a clone of Bug #1221270 +++

Description of problem:

Operations like detach-tier commit gives success for a non-tiered volume also 

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.create a tired volume
2.detach the tier
3.again try to detach (detach-tier commit)

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-13 17:15:37 CEST ---

REVIEW: http://review.gluster.org/10773 (tier: Do not allow detach-tier commands on a non-tiered volume) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

Comment 1 Anand Avati 2015-05-28 19:11:05 UTC

REVIEW: http://review.gluster.org/10979 (tier: Do not allow detach-tier commands on a non-tiered volume) posted (#1) for review on release-3.7 by mohammed rafi  kc (rkavunga)

Comment 2 Anand Avati 2015-06-01 04:33:09 UTC

COMMIT: http://review.gluster.org/10979 committed in release-3.7 by Kaushal M (kaushal) 
------
commit 151d01445eddb0bfbd46e13a79b2ed6d1779cc5e
Author: Mohammed Rafi KC <rkavunga>
Date:   Wed May 13 20:33:45 2015 +0530

    tier: Do not allow detach-tier commands on a non-tiered volume
    
            Back port of http://review.gluster.org/10773
    
     >Change-Id: Ic92d25db68e40ef4a4388ef42affd1b3ee5a7ec6
     >BUG: 1221270
     >Signed-off-by: Mohammed Rafi KC <rkavunga>
     >Reviewed-on: http://review.gluster.org/10773
     >Reviewed-by: Atin Mukherjee <amukherj>
     >Reviewed-by: Raghavendra G <rgowdapp>
     >Reviewed-by: Kaushal M <kaushal>
     >Tested-by: Gluster Build System <jenkins.com>
     >Tested-by: NetBSD Build System
     >Signed-off-by: Mohammed Rafi KC <rkavunga>
    
    Change-Id: I4b52da590dfcca8edc7e2b7e0c24c5dab7983c10
    BUG: 1221967
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/10979
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Joseph Fernandes
    Reviewed-by: Kaushal M <kaushal>

Comment 3 Niels de Vos 2015-06-02 08:02:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.1, please reopen this bug report.

glusterfs-3.7.1 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/1
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user