Bug 1222264 (php-ocramius-proxy-manager)
| Summary: | Review Request: php-ocramius-proxy-manager - OOP proxy wrappers utilities | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-ocramius-proxy-manager-1.0.0-2.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-06-10 19:05:54 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2015-05-17 03:27:07 UTC
Created attachment 1026428 [details]
phpci.log
phpCompatInfo version 4.1.0 DB built Apr 17 2015 07:48:16 UTC static analyze result
Created attachment 1026429 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Some comments about autoloader
- isn't ZendXml namespace needed ?
- isn't GeneratedHydrator needed if optional dep is installed ?
- as you have ZF2 in the dependencies, could make sense to use ZF2 autoloader, something like:
<?php
require_once ('Zend/Loader/StandardAutoloader.php');
$option = array(
Zend\Loader\StandardAutoloader::LOAD_NS => array(
'ProxyManager' => __DIR__,
'GeneratedHydrator' => '/usr/share/php/GeneratedHydrator',
),
Zend\Loader\StandardAutoloader::AUTOREGISTER_ZF => true,
);
$loader = new Zend\Loader\StandardAutoloader($option);
$loader->register();
Notice: using above test suite fails...
Fatal error: Declaration of generated55582f3846c13::__construct() must be compatible with Zend\Loader\SplAutoloader::__construct($options = NULL) in /dev/shm/extras/BUILDROOT/php-ocramius-proxy-manager-1.0.0-1.fc21.remi.x86_64/usr/share/php/ProxyManager/GeneratorStrategy/EvaluatingGeneratorStrategy.php(65) : eval()'d code on line 1
Which seems interesting bug....
No blocker, everything clean. === APPROVED === THANKS for the review! I'll touch up the autoloader after initial import. Thanks for catching the optional libraries issue. New Package SCM Request ======================= Package Name: php-ocramius-proxy-manager Short Description: OOP proxy wrappers utilities Upstream URL: http://ocramius.github.io/ProxyManager/ Owners: siwinski Branches: f21 f22 el6 epel7 InitialCC: Git done (by process-git-requests). php-ocramius-proxy-manager-1.0.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-ocramius-proxy-manager-1.0.0-2.fc21 php-ocramius-proxy-manager-1.0.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-ocramius-proxy-manager-1.0.0-2.fc22 php-ocramius-proxy-manager-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-ocramius-proxy-manager-1.0.0-2.el6 php-ocramius-proxy-manager-1.0.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-ocramius-proxy-manager-1.0.0-2.el7 php-ocramius-proxy-manager-1.0.0-2.fc21 has been pushed to the Fedora 21 testing repository. php-ocramius-proxy-manager-1.0.0-2.fc22 has been pushed to the Fedora 22 stable repository. php-ocramius-proxy-manager-1.0.0-2.fc21 has been pushed to the Fedora 21 stable repository. php-ocramius-proxy-manager-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. php-ocramius-proxy-manager-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |