Bug 1222269 (php-silex)

Summary: Review Request: php-silex - PHP micro-framework based on the Symfony components
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-silex-1.2.4-3.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-30 19:41:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1222272    
Bug Blocks: 1222270    
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2015-05-17 03:54:23 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/0c640b57a29c4bd29934fab5f5a92016feea2551/php-silex/php-silex.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-silex-1.2.4-1.fc21.src.rpm

Description:
Silex is a PHP micro-framework. It is built on the shoulders of Symfony and
Pimple and also inspired by Sinatra.

A micro-framework provides the guts for building simple single-file apps. Silex
aims to be:
* Concise: Silex exposes an intuitive and concise API that is fun to use
* Extensible: Silex has an extension system based around the Pimple micro
  service-container that makes it even easier to tie in third party libraries
* Testable: Silex uses Symfony's HttpKernel which abstracts requests and
  responses. This makes it very easy to test apps and the framework itself.
  It also respects the HTTP specification and encourages its' proper use.


Fedora Account System Username: siwinski
Comment 1 Shawn Iwinski 2015-05-17 05:09:12 UTC 
Fix php-composer(pimple/pimple) dependency



Spec URL: https://raw.githubusercontent.com/siwinski/rpms/9e9e5247faaaa1761ceb187808035f9c24cd7fa7/php-silex/php-silex.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-silex-1.2.4-2.fc21.src.rpm
Comment 2 Shawn Iwinski 2015-05-20 23:31:33 UTC 
"%{phpdir}/Pimple" => "%{phpdir}/Pimple1"



Spec URL: https://raw.githubusercontent.com/siwinski/rpms/921f62ec01a0294c41f77c2d937f75beea3516ab/php-silex/php-silex.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-silex-1.2.4-3.fc21.src.rpm
Comment 3 Remi Collet 2015-05-25 15:13:45 UTC 
Created attachment 1029503 [details]
phpci.log

phpCompatInfo version 4.2.0 DB built May 19 2015 11:12:39 CEST static analyze results
Comment 4 Remi Collet 2015-05-25 15:14:21 UTC 
Created attachment 1029504 [details]
review.txt

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Comment 5 Remi Collet 2015-05-25 15:16:05 UTC 
I notice you requires "some" optional dep, but not all => packager choice.


Everything seems OK.
No Blocker

=== APPROVED ===
Comment 6 Shawn Iwinski 2015-05-26 02:52:02 UTC 
THANKS for the review!



New Package SCM Request
=======================
Package Name: php-silex
Short Description: PHP micro-framework based on the Symfony components
Upstream URL: http://silex.sensiolabs.org
Owners: siwinski
Branches: f21 f22 el6 epel7
InitialCC:
Comment 7 Gwyn Ciesla 2015-05-26 19:21:10 UTC 
Git done (by process-git-requests).
Comment 8 Fedora Update System 2015-05-30 17:21:33 UTC 
php-silex-1.2.4-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-silex-1.2.4-3.fc21
Comment 9 Fedora Update System 2015-05-30 17:22:43 UTC 
php-silex-1.2.4-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/php-silex-1.2.4-3.fc22
Comment 10 Fedora Update System 2015-05-30 17:22:54 UTC 
php-silex-1.2.4-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-silex-1.2.4-3.el7
Comment 11 Fedora Update System 2015-06-10 19:08:40 UTC 
php-silex-1.2.4-3.fc21 has been pushed to the Fedora 21 stable repository.
Comment 12 Fedora Update System 2015-06-10 19:17:23 UTC 
php-silex-1.2.4-3.fc22 has been pushed to the Fedora 22 stable repository.
Comment 13 Fedora Update System 2015-06-18 18:32:52 UTC 
php-silex-1.2.4-3.el7 has been pushed to the Fedora EPEL 7 stable repository.