Bug 1222719
| Summary: | rtld-audit man example code uses wrong format for cookies | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Woodard <woodard> | ||||
| Component: | man-pages | Assignee: | Jan Chaloupka <jchaloup> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | jchaloup, tgummels | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | man-pages-3.53-6.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1222720 (view as bug list) | Environment: | |||||
| Last Closed: | 2015-05-30 15:40:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 975551, 1222720 | ||||||
| Attachments: |
|
||||||
I sent this to mtk.manpages to get it fixed upstream. Hi Ben, thanks for reporting this issue to upstream. Do you have a message id for your email? I can not find it on linux-man.org ML so far. It can take 1-2 days before it propagates on the ML. Jan I sent it off to Michael Kerrisk directly and got back this email today. Hadn't submitted a patch to linux-man before and wasn't familiar with that process. Michael seemed to be the maintainer and so I sent it to him.
From: "Michael Kerrisk (man-pages)" <mtk.manpages>
Subject: Re: patch for rtld-audit man page
Date: May 18, 2015 at 11:50:37 PM PDT
To: Ben Woodard <woodard>
Cc: mtk.manpages, "Carlos O'Donell" <codonell>
Hi Ben,
On 05/19/2015 02:05 AM, Ben Woodard wrote:
> Here is a patch to the rtld-audit man page. It is really simple and trivial. In
> the example code you used %x rather than %p in the example code for an audit
> library. The problem is that it truncates the pointers on 64b platforms. So you
> get something like:
>
> la_symbind64(): symname = strrchr sym->st_value = 0x7f4b8a3f8960
> ndx = 222 flags = 0x0 refcook = 8b53e5c8 defcook = 8b537e30
>
> rather than:
>
> la_symbind64(): symname = fclose sym->st_value = 0x7fa452dd49b0
> ndx = 1135 flags = 0x0 refcook = 0x7fa453f395c8 defcook = 0x7fa453f32e30
>
> This has bit me a handful of times when playing around with audit test libraries
> to investigate its behavior.
Thanks! Applied.
Cheers,
Michael
Thanks for his reply. If you don't mind I will wait for another release of man-pages instead of patching the current one. It is quite often. Is this issue relevant for f22 and lower? Yes it is relevant for F22 and lower. Change it when you like but it would be good to get it fixed rather than just having it languish. master: https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150518/1579522.html f22: https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150518/1579536.html f21: https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150518/1579535.html f20: https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150518/1579534.html man-pages-3.81-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/man-pages-3.81-2.fc22 man-pages-3.69-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/man-pages-3.69-3.fc21 man-pages-3.53-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/man-pages-3.53-5.fc20 Package man-pages-3.69-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing man-pages-3.69-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-8755/man-pages-3.69-3.fc21 then log in and leave karma (feedback). man-pages-3.53-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/man-pages-3.53-6.fc20 man-pages-3.69-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. man-pages-3.81-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. man-pages-3.53-6.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1026902 [details] Patch to fix the problem. Description of problem: Here is a patch to the rtld-audit man page. It is really simple and trivial. In the example code you used %x rather than %p in the example code for an audit library. The problem is that it truncates the pointers on 64b platforms. So you get something like: la_symbind64(): symname = strrchr sym->st_value = 0x7f4b8a3f8960 ndx = 222 flags = 0x0 refcook = 8b53e5c8 defcook = 8b537e30 rather than: la_symbind64(): symname = fclose sym->st_value = 0x7fa452dd49b0 ndx = 1135 flags = 0x0 refcook = 0x7fa453f395c8 defcook = 0x7fa453f32e30 This has bit me a handful of times when playing around with audit test libraries to investigate its behavior. Version-Release number of selected component (if applicable): all