Bug 1222799 (Horde_Stringprep)

Update to 1.0.2 https://github.com/remicollet/remirepo/commit/399b2837c22a1f2e19a855b2068fbf16cbf203f0

Spec: https://raw.githubusercontent.com/remicollet/remirepo/399b2837c22a1f2e19a855b2068fbf16cbf203f0/php/horde/php-horde-Horde-Stringprep/php-horde-Horde-Stringprep.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Stringprep-1.0.2-1.remi.src.rpm

@Shawn, would you have a few minutes to review this one which is now required to update the horde Stack ?

Created attachment 1041334 [details]
phpcompatinfo.txt

phpCompatInfo version 4.2.0 DB built May 22 2015 19:29:18 CEST

Created attachment 1041335 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1222799
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text



[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL5 bits after initial import.



[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.

     Patch is correct, but can't you just use the indlude path for the require?:
     require_once('Znerol/Component/Stringprep/autoload.php');

(In reply to Shawn Iwinski from comment #5)
> As usual, remove EPEL5 bits after initial import.

Yes, of course

> [x]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
> 
>      Patch is correct, but can't you just use the indlude path for the
> require?:
>      require_once('Znerol/Component/Stringprep/autoload.php');

I prefer to keep full path to avoid issue when include_path is not correct (which is the case when using PHP from RHSCL).

(In reply to Remi Collet from comment #6)
> > [x]: Patches link to upstream bugs/comments/lists or are otherwise
> >      justified.
> > 
> >      Patch is correct, but can't you just use the indlude path for the
> > require?:
> >      require_once('Znerol/Component/Stringprep/autoload.php');
> 
> I prefer to keep full path to avoid issue when include_path is not correct
> (which is the case when using PHP from RHSCL).

I did not know about the issue with the include_path in RHSCL.  Thanks!




Will you post the quick fix for the following blocking issue?:

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

> Will you post the quick fix for the following blocking issue?:

Not a so "quick" fix, even a nigthmare ;)

See: https://github.com/remicollet/remirepo/commit/9d07ff1e99b3355d7abd048ae22763a6118222a3

Perhaps I should simply have the COPYING file twice, one in pear location, per PHP Guildelines, one in %_licensedir, php License Guidelines.

Spec: https://raw.githubusercontent.com/remicollet/remirepo/9d07ff1e99b3355d7abd048ae22763a6118222a3/php/horde/php-horde-Horde-Stringprep/php-horde-Horde-Stringprep.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Stringprep-1.0.2-2.remi.src.rpm

No blockers.



===== APPROVED =====

Thanks a lot!

New Package SCM Request
=======================
Package Name: php-horde-Horde-Stringprep
Short Description: Preparation of Internationalized Strings ("stringprep")
Upstream URL: http://www.horde.org/
Owners: remi
Branches: f21 f22 el6 epel7
InitialCC:

Git done (by process-git-requests).

php-horde-Horde-Stringprep-1.0.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-horde-Horde-Stringprep-1.0.2-2.fc21

php-horde-Horde-Stringprep-1.0.2-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Stringprep-1.0.2-2.el6

php-horde-Horde-Stringprep-1.0.2-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/php-horde-Horde-Stringprep-1.0.2-2.fc22

php-horde-Horde-Stringprep-1.0.2-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-horde-Horde-Stringprep-1.0.2-2.el7

php-horde-Horde-Stringprep-1.0.2-2.fc21 has been pushed to the Fedora 21 testing repository.

php-horde-Horde-Stringprep-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository.

php-horde-Horde-Stringprep-1.0.2-2.fc22 has been pushed to the Fedora 22 stable repository.

php-horde-Horde-Stringprep-1.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

php-horde-Horde-Stringprep-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository.