Bug 1223440
| Summary: | Review Request: nodejs-string_decoder - The string_decoder module from Node core | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-23 12:35:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralph Bean
2015-05-20 14:00:23 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9806646 Review:
+ mock build is successful for F23 x86_64
- rpmlint on generated rpms gave output
nodejs-string_decoder.noarch: W: incoherent-version-in-changelog 0.11.10-0.1.1 ['0.10.31-1.fc23', '0.10.31-1']
nodejs-string_decoder.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
+ License is "MIT" which is valid and included in LICENSE file
+ Source verified with upstream as sha256sum
tarball in srpm: 3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086
upstream tarball: 3e6e6ffeafe6157eb2278a909afc0b845234b13446dca8a9518c2b79b9c22086
Suggestions:
1) Group tag is not even needed on EPEL6 so can be removed safely.
2) I have seen missing files in source archive from npm repository. This package also if using source from npm repository you will not get extra files like test cases. Either you can ask upstream to include it in and release new tarball or use github release tarball.
For this package I don't see recent release in 0.10.x series tagged on github. So, good to ask upstream to include test files or else remove test related lines in spec file.
3) Maybe you want to drop following macro as we no longer support < F20 releases.
%if 0%{?fedora} >= 19
4) Use %license macro for LICENSE
I filed an issue with upstream to ask them to include the tests in future releases: https://github.com/substack/string_decoder/issues/3 And here's a new release that should take care of everything else: Spec URL: http://threebean.org/rpm/SPECS/nodejs-string_decoder.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-string_decoder-0.10.31-2.fc22.src.rpm Looks good now. APPROVED. New Package SCM Request ======================= Package Name: nodejs-string_decoder Short Description: The string_decoder module from Node core Upstream URL: https://npmjs.org/package/string_decoder Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: Git done (by process-git-requests). I somehow forgot f22. :( Package Change Request ====================== Package Name: nodejs-string_decoder New Branches: f22 Owners: ralph InitialCC: nodejs-string_decoder-0.10.31-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc21 nodejs-string_decoder-0.10.31-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc20 Git done (by process-git-requests). nodejs-string_decoder-0.10.31-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-string_decoder-0.10.31-2.fc22 Updates and buildroot overrides created. nodejs-string_decoder-0.10.31-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-string_decoder-0.10.31-2.fc22 has been pushed to the Fedora 22 stable repository. nodejs-string_decoder-0.10.31-2.fc21 has been pushed to the Fedora 21 stable repository. |