Bug 1223672

Summary:	Node registration fails silently if instackenv.json is badly formatted
Product:	[Community] RDO	Reporter:	Udi Kalifon <ukalifon>
Component:	openstack-tripleo	Assignee:	James Slagle <jslagle>
Status:	CLOSED EOL	QA Contact:	Shai Revivo <srevivo>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	trunk	CC:	bugzilla
Target Milestone:	---
Target Release:	Kilo
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-19 15:42:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Udi Kalifon 2015-05-21 08:03:09 UTC

Description of problem:
I ommitted a few fields from the nodes in instackenv.json, such as number of cpus and memory, and ran the command "instack-ironic-deployment --nodes-json instackenv.json --register-nodes". The command exited silently without any errors (apart from the non-zero exit status). It's important that the user get a clear failure reason and know that the operation failed.


Version-Release number of selected component (if applicable):
instack-0.0.6-1.el7ost.noarch
instack-undercloud-2.1.1-dev14.el7.centos.noarch


How reproducible:
100%


Steps to Reproduce:
1. Use a sample instackenv.json file such as http://file.tlv.redhat.com/~ukalifon/instackenv.json
2. Delete some of the fields in one of the nodes, such as the number of cpus or memory
3. Run "instack-ironic-deployment --nodes-json instackenv.json --register-nodes"


Actual results:
No error message

Comment 2 Mohammed Arafa 2015-10-09 21:37:57 UTC

for those that have this problem and are trying to get to the server which i suspect is internal, there is another sample online at  https://www.rdoproject.org/Instack_FAQ#What_is_the_NODES_JSON_file_format.3F 

oh and it also affects rhosp director 7

Comment 4 Chandan Kumar 2016-05-19 15:42:20 UTC

This bug is against a Version which has reached End of Life.
If it's still present in supported release (http://releases.openstack.org), please update Version and reopen.