Bug 1223964

Summary:	libssh 0.7.0 regression breaks cockpit and cockpit test suite
Product:	[Fedora] Fedora	Reporter:	Stef Walter <stefw>
Component:	libssh	Assignee:	Andreas Schneider <asn>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	asn, dperpeet, jscotka, mvollmer, negativo17, orion, pvolpe, rdieter
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libssh-0.7.1-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-14 15:28:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stef Walter 2015-05-21 19:44:19 UTC

Description of problem:

libssh 0.7.0 breaks cockpit and the cockpit test suite. In particular the ssh_channel_callbacks_struct.channel_exit_status_function function in a libssh client caller is invoked with a -1 exit_status argument even when the server returns a zero exit status. 

Version-Release number of selected component (if applicable):

libssh-0.7.0-1.fc22.x86_64

How reproducible:

Always

Steps to Reproduce:
1. Build cockpit from source
2. Run 'make test'

Comment 1 Orion Poplawski 2015-05-21 19:49:05 UTC

Has this been reported upstream? https://red.libssh.org/projects/libssh

Comment 2 Stef Walter 2015-05-21 19:55:39 UTC

No not yet. 

The most important thing is that this doesn't break its dependencies in a stable frozen version of the operating system: Fedora 22.

After that we may be able to help narrowing down the problem further.

Comment 3 Orion Poplawski 2015-05-21 19:58:02 UTC

Yeah, thanks for the heads up.  I've disabled automatic karma push just in case.  Sounds like Andreas may be on vacation, so the response may be slow...

Comment 4 Andreas Schneider 2015-06-24 14:20:35 UTC

We've fixed that already. I will release libssh 0.7.1 soon.

https://git.libssh.org/projects/libssh.git/commit/?id=c480a29052ea49ecd4a4e59d3332cbd6546ed942

Comment 5 Fedora Update System 2015-06-30 08:15:48 UTC

libssh-0.7.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/libssh-0.7.1-1.fc22

Comment 6 Fedora Update System 2015-06-30 20:15:27 UTC

Package libssh-0.7.1-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libssh-0.7.1-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-10962/libssh-0.7.1-1.fc22
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2015-07-14 15:28:41 UTC

libssh-0.7.1-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.