Bug 1224098

Summary:	[geo-rep]: Even after successful sync, the DATA counter did not reset to 0
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	aavati, bugs, csaba, gluster-bugs, nlevinki, rhinduja, rhs-bugs, storage-qa-internal
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1223695
Clones:	1224100 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:04:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1223636, 1223695, 1224100

Description Aravinda VK 2015-05-22 08:24:55 UTC

+++ This bug was initially created as a clone of Bug #1223695 +++

Description of problem:
=======================

The purpose of DATA counter in "status detail" is to provide information about the pending que to sync. Once the sync is successful, the counter should reset to 0. Which is not happening.

[root@georep1 scripts]# gluster volume geo-replication master 10.70.46.154::slave status detail
 
MASTER NODE    MASTER VOL    MASTER BRICK      SLAVE USER    SLAVE                  SLAVE NODE      STATUS     CRAWL STATUS       LAST_SYNCED            ENTRY    DATA    META    FAILURES    CHECKPOINT TIME        CHECKPOINT COMPLETED    CHECKPOINT COMPLETION TIME   
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
georep1        master        /rhs/brick1/b1    root          10.70.46.154::slave    10.70.46.101    Passive    N/A                N/A                    N/A      N/A     N/A     N/A         N/A                    N/A                     N/A                          
georep1        master        /rhs/brick2/b2    root          10.70.46.154::slave    10.70.46.101    Passive    N/A                N/A                    N/A      N/A     N/A     N/A         N/A                    N/A                     N/A                          
georep3        master        /rhs/brick1/b1    root          10.70.46.154::slave    10.70.46.154    Active     Changelog Crawl    2015-05-21 14:03:50    0        377     0       0           2015-05-21 14:32:54    No                      N/A                          
georep3        master        /rhs/brick2/b2    root          10.70.46.154::slave    10.70.46.154    Active     Changelog Crawl    2015-05-21 14:32:20    0        372     0       0           2015-05-21 14:32:54    No                      N/A                          
georep2        master        /rhs/brick1/b1    root          10.70.46.154::slave    10.70.46.103    Passive    N/A                N/A                    N/A      N/A     N/A     N/A         N/A                    N/A                     N/A                          
georep2        master        /rhs/brick2/b2    root          10.70.46.154::slave    10.70.46.103    Passive    N/A                N/A                    N/A      N/A     N/A     N/A         N/A                    N/A                     N/A                          
[root@georep1 scripts]# 


Version-Release number of selected component (if applicable):
=============================================================
glusterfs-3.7.0


How reproducible:
=================
2/2


Steps to Reproduce:
===================
1. Create and Start master volume
2. Create and Start slave volume
3. Create and Start meta volume
4. Create and Start geo-rep between master and slave
5. Mount the master and slave volume
6. Create files/directories on the master volume.
7. Execute status detail command from master node. You will observe the increment in the entry and data counter. 
8. Let the sync complete.
9. Calculate checksum of master and slave volume to confirm that the sync is completed.
10. Once sync complete, check the status detail again.

Actual results:
===============

The entry counter is reset to 0, but data counter is still has values like 377


Expected results:
=================

All the counters should reset to 0, indicating that nothing is pending to sync.


Additional info:
=================

Arequal infor for master and slave


[root@wingo master]# /root/scripts/arequal-checksum -p /mnt/master

Entry counts
Regular files   : 519
Directories     : 140
Symbolic links  : 114
Other           : 0
Total           : 773

Metadata checksums
Regular files   : 47e250
Directories     : 3e9
Symbolic links  : 3e9
Other           : 3e9

Checksums
Regular files   : 4f4af7ac217c3da67e7270a056d2fba
Directories     : 356e0d5141064d2c
Symbolic links  : 7313722a0c5b0a7b
Other           : 0
Total           : ed0afdd694c554b
[root@wingo master]# 


[root@wingo slave]# /root/scripts/arequal-checksum -p /mnt/slave

Entry counts
Regular files   : 519
Directories     : 140
Symbolic links  : 114
Other           : 0
Total           : 773

Metadata checksums
Regular files   : 47e250
Directories     : 3e9
Symbolic links  : 3e9
Other           : 3e9

Checksums
Regular files   : 4f4af7ac217c3da67e7270a056d2fba
Directories     : 356e0d5141064d2c
Symbolic links  : 7313722a0c5b0a7b
Other           : 0
Total           : ed0afdd694c554b
[root@wingo slave]#

Comment 1 Anand Avati 2015-05-26 08:21:18 UTC

REVIEW: http://review.gluster.org/10911 (geo-rep: Fix Data counter issue in status) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 2 Anand Avati 2015-05-28 07:03:57 UTC

REVIEW: http://review.gluster.org/10911 (geo-rep: Fix Data counter issue in status) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2015-05-28 07:08:50 UTC

REVIEW: http://review.gluster.org/10911 (geo-rep: Fix Data counter issue in status) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 4 Anand Avati 2015-05-29 06:10:58 UTC

REVIEW: http://review.gluster.org/10911 (geo-rep: Fix Data counter issue in status) posted (#4) for review on master by Aravinda VK (avishwan)

Comment 5 Anand Avati 2015-05-31 05:19:12 UTC

COMMIT: http://review.gluster.org/10911 committed in master by Venky Shankar (vshankar) 
------
commit 5863ab43d7f3b045f5b889b98f73687b07b3f0e8
Author: Aravinda VK <avishwan>
Date:   Tue May 26 13:01:17 2015 +0530

    geo-rep: Fix Data counter issue in status
    
    ENTRY and META operations executed sequentially, DATA operations
    are handled async, increment happens when a changelog parsed.
    Decrement happens after the sync of all files.
    
    'files_in_batch' was reset multiple times in batch instead of once.
    
    BUG: 1224098
    Change-Id: I87617f2fd5f4d3221a1c9f9d5a8efb0686c42bbe
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/10911
    Reviewed-by: Kotresh HR <khiremat>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Niels de Vos 2016-06-16 13:04:41 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user