Bug 1224353

Summary: Review Request: php-d11wtq-boris - A tiny, but robust REPL (Read-Evaluate-Print-Loop) for PHP
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-d11wtq-boris-1.0.10-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-10 19:10:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2015-05-22 15:53:58 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/59a2459bc7016c0ba5dca2ede3393001e0d9c83e/php-d11wtq-boris/php-d11wtq-boris.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-d11wtq-boris-1.0.10-1.fc21.src.rpm

Description:
Python has one. Ruby has one. Clojure has one. Now PHP has one, too. Boris is
PHP's missing REPL (read-eval-print loop), allowing developers to experiment
with PHP code in the terminal in an interactive manner. If you make a mistake,
it doesn't matter, Boris will report the error and stand to attention for
further input.

Everything you enter into Boris is evaluated and the result inspected so you
can understand what is happening. State is maintained between inputs, allowing
you to gradually build up a solution to a problem.


Fedora Account System Username: siwinski

--

Requirement of latest drush release

Comment 1 Remi Collet 2015-05-23 06:22:18 UTC
Created attachment 1028994 [details]
phpci.log

phpCompatInfo version 4.2.0 DB built May 19 2015 11:12:39 CEST static analyze results

Comment 2 Remi Collet 2015-05-23 06:22:53 UTC
Created attachment 1028995 [details]
review.txt

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04

Comment 3 Remi Collet 2015-05-23 06:24:30 UTC
[x]: Package is named according to the Package Naming Guidelines.
  As this is more an app than a library
  "boris" could have be an acceptable name
  but perhaps a little to generic. php-d11wtq-boris is OK.
  
[!]: Final provides and requires are sane (see attachments).
  Missing explicit requires on php-cli, This is the tricky bit using "env" ;)
  Implicitly required by php-readline, so not a blocker.


Everything seems OK.

=== APPROVED ===

Comment 4 Shawn Iwinski 2015-05-23 17:53:15 UTC
THANKS for the review!  I'll add the explicit php-cli requires (in place of the php(language) require) after initial import.



New Package SCM Request
=======================
Package Name: php-d11wtq-boris
Short Description: A tiny, but robust REPL (Read-Evaluate-Print-Loop) for PHP
Upstream URL: https://github.com/borisrepl/boris
Owners: siwinski
Branches: f21 f22 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2015-05-24 20:36:52 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-05-30 19:29:24 UTC
php-d11wtq-boris-1.0.10-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-d11wtq-boris-1.0.10-2.fc21

Comment 7 Fedora Update System 2015-05-30 19:29:33 UTC
php-d11wtq-boris-1.0.10-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/php-d11wtq-boris-1.0.10-2.fc22

Comment 8 Fedora Update System 2015-05-30 19:29:39 UTC
php-d11wtq-boris-1.0.10-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-d11wtq-boris-1.0.10-2.el6

Comment 9 Fedora Update System 2015-05-30 19:29:46 UTC
php-d11wtq-boris-1.0.10-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/php-d11wtq-boris-1.0.10-2.el7

Comment 10 Fedora Update System 2015-06-01 17:05:01 UTC
php-d11wtq-boris-1.0.10-2.fc22 has been pushed to the Fedora 22 testing repository.

Comment 11 Fedora Update System 2015-06-10 19:10:05 UTC
php-d11wtq-boris-1.0.10-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 12 Fedora Update System 2015-06-10 19:16:53 UTC
php-d11wtq-boris-1.0.10-2.fc22 has been pushed to the Fedora 22 stable repository.

Comment 13 Fedora Update System 2015-06-18 18:33:53 UTC
php-d11wtq-boris-1.0.10-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 14 Fedora Update System 2015-06-18 18:36:52 UTC
php-d11wtq-boris-1.0.10-2.el7 has been pushed to the Fedora EPEL 7 stable repository.