Bug 1224574

Summary: Review Request: owncloud-news - RSS/Atom feed aggregator for OwnCloud
Product: [Fedora] Fedora Reporter: Igor Gnatenko <ignatenko>
Component: Package ReviewAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ignatenko, kwizart, package-review, zbyszek
Target Milestone: ---Flags: zbyszek: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-28 12:52:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Gnatenko 2015-05-24 20:38:50 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/owncloud-news.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/owncloud-news-5.3.4-1.fc23.src.rpm
Description: RSS/Atom feed aggregator for OwnCloud
Fedora Account System Username: ignatenkobrain
Comment 1 Zbigniew Jędrzejewski-Szmek 2015-06-04 14:16:39 UTC 
It's not an area I know anything about, but since there are no takers, I'll do the review... 

At first sight:
Can you beef up %description? "cloud" is a popular yet nebulous term, and I think some explanation in the form "This allows you to ..." would be great.

owncloud-news.noarch: E: version-control-internal-file /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/.gitignore
owncloud-news.noarch: E: version-control-internal-file /usr/share/owncloud/apps/news/vendor/fguillot/picofeed/.gitignore
owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/js/.jshintrc
owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.tx
owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.tx
owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/l10n/.gitkeep
owncloud-news.noarch: E: zero-length /usr/share/owncloud/apps/news/l10n/.gitkeep
owncloud-news.noarch: W: hidden-file-or-dir /usr/share/owncloud/apps/news/js/vendor/angular-mocks/.bower.json
...

So .gitignores and .gitkeeps should be removed. Other hidden files: dunno.

owncloud-news.noarch: E: non-executable-script /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/maintenance/update-freshmeat.php 0644L /usr/bin/php
owncloud-news.noarch: E: non-executable-script /usr/share/owncloud/apps/news/vendor/ezyang/htmlpurifier/maintenance/old-remove-require-once.php 0644L /usr/bin/php

If those are supposed to be run by the admin, then chmod +x.

-exec rm -f {} → -delete ?


Requires
--------
owncloud-news (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    /usr/bin/env
    /usr/bin/php
    /usr/bin/python3

/usr/share/owncloud/apps/news/vendor/fguillot/picofeed/picofeed:#!/usr/bin/env php
/usr/lib/python3.4/site-packages/owncloud_news_updater/application.py:#!/usr/bin/env python3
/usr/lib/python3.4/site-packages/owncloud_news_updater/updater.py:#!/usr/bin/env python3

I'd change those to /usr/bin/php and %{__python3}. Just to keep things clean and match other files.

/usr/share/licenses/owncloud-news/{COPYING,LICENSE.txt} are duplicated. Just one should be enough.
Comment 2 Nicolas Chauvet (kwizart) 2015-06-16 12:50:46 UTC 
Hello, What is the status of this review ?
Does the 5.3.7 update works with current owncloud 8.x ?
Thx
Comment 3 Igor Gnatenko 2016-06-28 12:52:39 UTC 
It's painful, so I'm not going to continue.