Bug 1224650
| Summary: | SIGNING FAILURE Error messages are poping up in the bitd log | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Venky Shankar <vshankar> |
| Component: | bitrot | Assignee: | Venky Shankar <vshankar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | RajeshReddy <rmekala> |
| Severity: | unspecified | Docs Contact: | bugs <bugs> |
| Priority: | unspecified | ||
| Version: | 3.7.0 | CC: | bugs, mzywusko, rmekala, vshankar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1221938 | Environment: | |
| Last Closed: | 2015-06-02 08:03:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1221938 | ||
| Bug Blocks: | 1219955 | ||
|
Description
Venky Shankar
2015-05-25 09:01:40 UTC
REVIEW: http://review.gluster.org/10900 (features/bitrot: serialize versioning) posted (#2) for review on release-3.7 by Venky Shankar (vshankar) REVIEW: http://review.gluster.org/10900 (features/bitrot: serialize versioning) posted (#3) for review on release-3.7 by Venky Shankar (vshankar) COMMIT: http://review.gluster.org/10900 committed in release-3.7 by Venky Shankar (vshankar) ------ commit 06710aa1085a7c5f3259af6b63d23ac5f51bef18 Author: Venky Shankar <vshankar> Date: Fri May 29 10:00:13 2015 +0530 features/bitrot: serialize versioning Backport of http://review.gluster.org/10832 Current signing interface (fsetxattr()) had couple of issues: One, a signing request (by bitrot daemon) is denied if the version against which an object is to be signed is unequal to the current version of the object (cases where another subsequent modification increments the version). Such request(s) are rejected with EINVAL sent back to the signer resulting in a bunch of errors (in logs) reported by bitrot daemon. Although, the object would be eventaully signed with the version matching the current version, the "lagging" request should be correctly handled. Two, more than one signing request could race against each other with the object getting signed with a version depending on which request ended up last in the race. Although harmless to some extent, such a case could end up marking the object's signature as stale for infinity (if the object is *never* touched) thereby resulting in scrubber skipping the object during verification. This patch fixes these issues by ordering signing request(s) and fixing version comparison checks at the time of signing. Change-Id: I9fa83dfa3be664ba4db61d7f2edc408f4bde77dd BUG: 1224650 Signed-off-by: Venky Shankar <vshankar> Tested-by: Gluster Build System <jenkins.com> Reviewed-on: http://review.gluster.org/10900 Tested-by: NetBSD Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.1, please reopen this bug report. glusterfs-3.7.1 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/1 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |