Bug 1224912

Summary: [RFE] Please add a filter "Last modified by translators other than <user>"
Product: [Retired] Zanata Reporter: Yuko Katabami <ykatabam>
Component: Component-UIAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Damian Jansen <djansen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.6CC: dchen, djansen, lbrooker, mkim, zanata-bugs
Target Milestone: ---   
Target Release: 3.8   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: 3.8.0-SNAPSHOT (git-server-3.6.2-551-geff6365) Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-21 01:40:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yuko Katabami 2015-05-26 08:03:01 UTC
Description of problem:

Zanata currently has "last modified by" filter but it would be convenient if we could also have a filter "Last modified by translators other than <user>" when a user would like to review translations done by other translators.

This is particularly useful if we do not know who have edited a particular project, in external instance of Zanata, to which anyone who has an account and is a member of the language group can edit the translations.

Comment 1 Michelle Kim 2015-06-10 22:45:21 UTC
Hi Carlos,

Can I ask you to assign this RFE to someone in the team to estimate the points?
So this is RFE is to add new filtering option in our search box in our editor to find strings that was last modified by translator other than <user>.

For example, if I want to find strings that are translated by someone other than username <blah>, i will use the filtering to find all the other strings translated by other translators. This main use case is for review purpose, when you want to do a review of translations done by others.


Comment 2 Carlos Munoz 2015-06-11 00:17:10 UTC
Assigning to Alex for investigation.

Comment 3 Luke Brooker 2015-06-11 01:06:33 UTC
Would it make more sense to just add a "-" in front of a username when using the last modified by filter?

Like gmail https://support.google.com/mail/answer/7190?hl=en&rd=1

e.g. last-modified-by:-lbrooker@redhat.com

This could then be applied to other situations or even words.

e.g. Jboss -EAP

This should make it more flexible.

Comment 4 Luke Brooker 2015-06-11 01:09:50 UTC
Or possibly add it before the typo, like Github does:

e.g. -last-modified-by:lbrooker@redhat.com

Comment 5 Alex Eng 2015-06-11 06:03:26 UTC
If going forward with the "-" implementation, only FilterContraintToQuery class will be affected. 

- Parsing the "-" as exclude term param and handle it.
- if exclude, that means only show translations 
  - from anonymous user 
  - or that are not from given username.

Comment 6 Alex Eng 2015-07-06 23:56:32 UTC
Pull request:

Comment 7 Alex Eng 2015-07-07 00:30:19 UTC

Going forward with "-" for exclude in search.

Comment 8 Damian Jansen 2015-07-07 01:09:44 UTC
Verified at eff63659f4f4bf8126eecc533cb40e117396e03d