Bug 1224972
| Summary: | rsyslog logrotate issue | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Morten Stevens <ms> |
| Component: | rsyslog | Assignee: | Tomas Heinrich <theinric> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | ahmadsamir3891, bugzilla.redhat.com, chemobejk, ed.greshko, fabrice, jeff.raber, jhaar, jlieskov, jwakely, jwelsh-rhbz, lkundrak, mah.darade, ol+redhat, ondrejj, pvrabec, redhat-bugzilla, rmj, shulikov, terje.rosten, theinric, zaitcev |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rsyslog-8.8.0-3.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-12 17:16:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Morten Stevens
2015-05-26 10:26:27 UTC
it could be caused by the postrotate command in /etc/logrotate.d/syslog, that assumes the rsyslogd PID file is /var/run/syslogd.pid, instead of /var/run/rsyslogd.pid (In reply to Fabrice Bellet from comment #1) > it could be caused by the postrotate command in /etc/logrotate.d/syslog, > that assumes the rsyslogd PID file is /var/run/syslogd.pid, instead of > /var/run/rsyslogd.pid Yes, that sounds very likely. confirmed - I was about to report this bug when I found this. Just change /var/run/syslog.pid to /var/log/rsyslog.pid to fix the problem Looks like a screwup on my part. I'll change the settings with the next update. It's actually a regression upstream: https://github.com/rsyslog/rsyslog/issues/86 *** Bug 1231406 has been marked as a duplicate of this bug. *** *** Bug 1234358 has been marked as a duplicate of this bug. *** *** Bug 1235173 has been marked as a duplicate of this bug. *** Confirmed. Running manually # kill -HUP $(cat /var/run/rsyslogd.pid) on my F22 box causes rsyslog to switch to the new logfiles. Not sure what the agreed standard on this is, but given we have systemd now we might as well make use of it: systemctl kill -s HUP rsyslog And noone has to know where the PID file is on any given day. (In reply to Ralf Ertzinger from comment #10) > Not sure what the agreed standard on this is, but given we have systemd now > we might as well make use of it: > > systemctl kill -s HUP rsyslog > > And noone has to know where the PID file is on any given day. Sounds like an improvement. I'll push this change to, and probably only to, current rawhide. (In reply to Tomas Heinrich from comment #11) > (In reply to Ralf Ertzinger from comment #10) > > Not sure what the agreed standard on this is, but given we have systemd now > > we might as well make use of it: > > > > systemctl kill -s HUP rsyslog > > > > And noone has to know where the PID file is on any given day. > > Sounds like an improvement. I'll push this change to, and probably only to, > current rawhide. Are you planning to make any fix to the F22 package? (In reply to Roderick Johnstone from comment #12) > Are you planning to make any fix to the F22 package? Of course. Just not this particular change. The backlog for this particular rebase got a bit long... *** Bug 1237298 has been marked as a duplicate of this bug. *** rsyslog-8.8.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/rsyslog-8.8.0-3.fc22 Package rsyslog-8.8.0-3.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rsyslog-8.8.0-3.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11039/rsyslog-8.8.0-3.fc22 then log in and leave karma (feedback). rsyslog-8.8.0-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. Hi Tomas,
this change breaks parallel install of rsyslog and syslog-ng.
rsyslog and syslog-ng both uses /var/run/syslogd.pid as pidfile,
as an side effect they can both install identical versions of
/etc/logrotate.d/syslog and both can be installed at the same time.
When adding rsyslog specific calls into /etc/logrotate.d/syslog you break
this design.
rsyslog as of rsyslog-8.10.0-1.fc23.x86_64 uses pidfile /var/run/syslogd.pid
and the previous line of
/bin/kill -HUP `cat /var/run/syslogd.pid 2> /dev/null` 2> /dev/null || true
still works.
{ If you refuse to revert this change, at least mark syslog-ng as conflict
rsyslog, this way dnf can remove rsyslog when installing syslog-ng. }
(In reply to Terje Røsten from comment #18) > Hi Tomas, Hi, > this change breaks parallel install of rsyslog and syslog-ng. the change you describe is unrelated to the original issue in this bug and it only affects f23 while this bz is filed for f22. Hence I'm closing this bz again. I've created bug 1297878 with your description for the new issue. Let's continue the discussion there. |