Bug 1225073
| Summary: | Review Request: perl-MouseX-NativeTraits - Extend your attribute interfaces for Mouse | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-MouseX-NativeTraits-1.09-1.fc23 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-06-22 15:09:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1230173 | ||
|
Description
Jitka Plesnikova
2015-05-26 14:04:06 UTC
*** This bug has been marked as a duplicate of bug 1126046 *** URL and Source0 are usable. Ok.
Source archive is original (SHA-256: f8a5bf5a28702dfb13c8093be5c41cab9c5fc1c5d247ab91e22e7dd72764cb5e). Ok.
Patch is good. Ok.
Summary and Description are Ok.
License verified from lib/MouseX/NativeTraits.pm. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Do not build-require `perl(vars)'. It's only required from bundled ./inc which is not used.
FIX: Build-require coreutils (perl-MouseX-NativeTraits.spec:44).
FIX: Build-require sed (perl-MouseX-NativeTraits.spec:45).
FIX: Build-require findutils (perl-MouseX-NativeTraits.spec:46).
FIX: Build-require make (perl-MouseX-NativeTraits.spec:50).
All tests pass. Ok.
$ rpmlint perl-MouseX-NativeTraits.spec ../SRPMS/perl-MouseX-NativeTraits-1.09-1.fc23.src.rpm ../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US clearers -> clearer, cleaners, cleavers
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US clearers -> clearer, cleaners, cleavers
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/doc/perl-MouseX-NativeTraits
-rw-r--r-- 1 root root 1227 Nov 26 2012 /usr/share/doc/perl-MouseX-NativeTraits/Changes
-rw-r--r-- 1 root root 550 Nov 26 2012 /usr/share/doc/perl-MouseX-NativeTraits/README
-rw-r--r-- 1 root root 1249 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Array.3pm.gz
-rw-r--r-- 1 root root 1246 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Bool.3pm.gz
-rw-r--r-- 1 root root 1247 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Code.3pm.gz
-rw-r--r-- 1 root root 1243 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Counter.3pm.gz
-rw-r--r-- 1 root root 1249 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Hash.3pm.gz
-rw-r--r-- 1 root root 1244 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::Number.3pm.gz
-rw-r--r-- 1 root root 1244 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Custom::Trait::String.3pm.gz
-rw-r--r-- 1 root root 1301 Jun 22 13:56 /usr/share/man/man3/Mouse::Meta::Attribute::Native.3pm.gz
-rw-r--r-- 1 root root 2863 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits.3pm.gz
-rw-r--r-- 1 root root 3574 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::ArrayRef.3pm.gz
-rw-r--r-- 1 root root 1741 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::Bool.3pm.gz
-rw-r--r-- 1 root root 1479 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::CodeRef.3pm.gz
-rw-r--r-- 1 root root 1886 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::Counter.3pm.gz
-rw-r--r-- 1 root root 2153 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::HashRef.3pm.gz
-rw-r--r-- 1 root root 1337 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider.3pm.gz
-rw-r--r-- 1 root root 1628 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::ArrayRef.3pm.gz
-rw-r--r-- 1 root root 1312 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::Bool.3pm.gz
-rw-r--r-- 1 root root 1299 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::CodeRef.3pm.gz
-rw-r--r-- 1 root root 1310 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::Counter.3pm.gz
-rw-r--r-- 1 root root 1482 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::HashRef.3pm.gz
-rw-r--r-- 1 root root 1327 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::Num.3pm.gz
-rw-r--r-- 1 root root 1387 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::MethodProvider::Str.3pm.gz
-rw-r--r-- 1 root root 1763 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::Num.3pm.gz
-rw-r--r-- 1 root root 2169 Jun 22 13:56 /usr/share/man/man3/MouseX::NativeTraits::Str.3pm.gz
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/Mouse
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/Mouse/Meta
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait
-rw-r--r-- 1 root root 446 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Array.pm
-rw-r--r-- 1 root root 430 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Bool.pm
-rw-r--r-- 1 root root 439 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Code.pm
-rw-r--r-- 1 root root 448 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Counter.pm
-rw-r--r-- 1 root root 439 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Hash.pm
-rw-r--r-- 1 root root 438 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/Number.pm
-rw-r--r-- 1 root root 429 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Custom/Trait/String.pm
-rw-r--r-- 1 root root 520 Nov 26 2012 /usr/share/perl5/vendor_perl/Mouse/Meta/Attribute/Native.pm
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/MouseX
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/MouseX/NativeTraits
-rw-r--r-- 1 root root 6861 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits.pm
-rw-r--r-- 1 root root 7097 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/ArrayRef.pm
-rw-r--r-- 1 root root 1592 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/Bool.pm
-rw-r--r-- 1 root root 962 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/CodeRef.pm
-rw-r--r-- 1 root root 2070 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/Counter.pm
-rw-r--r-- 1 root root 2574 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/HashRef.pm
drwxr-xr-x 2 root root 0 Jun 22 13:56 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider
-rw-r--r-- 1 root root 2485 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider.pm
-rw-r--r-- 1 root root 15868 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/ArrayRef.pm
-rw-r--r-- 1 root root 1524 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/Bool.pm
-rw-r--r-- 1 root root 932 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/CodeRef.pm
-rw-r--r-- 1 root root 2923 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/Counter.pm
-rw-r--r-- 1 root root 8808 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/HashRef.pm
-rw-r--r-- 1 root root 3062 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/Num.pm
-rw-r--r-- 1 root root 7165 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/MethodProvider/Str.pm
-rw-r--r-- 1 root root 1796 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/Num.pm
-rw-r--r-- 1 root root 2602 Nov 26 2012 /usr/share/perl5/vendor_perl/MouseX/NativeTraits/Str.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm | sort -f | uniq -c
1 perl >= 0:5.006_002
1 perl(:MODULE_COMPAT_5.22.0)
1 perl(List::Util)
1 perl(Mouse) >= 0.82
1 perl(Mouse::Role)
1 perl(Mouse::Util::TypeConstraints)
1 perl(strict)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm | sort -f | uniq -c
1 perl(Mouse::Meta::Attribute::Custom::Trait::Array)
1 perl(Mouse::Meta::Attribute::Custom::Trait::Bool)
1 perl(Mouse::Meta::Attribute::Custom::Trait::Code)
1 perl(Mouse::Meta::Attribute::Custom::Trait::Counter)
1 perl(Mouse::Meta::Attribute::Custom::Trait::Hash)
1 perl(Mouse::Meta::Attribute::Custom::Trait::Number)
1 perl(Mouse::Meta::Attribute::Custom::Trait::String)
1 perl(Mouse::Meta::Attribute::Native) = 1.09
1 perl(MouseX::NativeTraits) = 1.09
1 perl(MouseX::NativeTraits::ArrayRef)
1 perl(MouseX::NativeTraits::Bool)
1 perl(MouseX::NativeTraits::CodeRef)
1 perl(MouseX::NativeTraits::Counter)
1 perl(MouseX::NativeTraits::HashRef)
1 perl(MouseX::NativeTraits::MethodProvider)
1 perl(MouseX::NativeTraits::MethodProvider::ArrayRef)
1 perl(MouseX::NativeTraits::MethodProvider::Bool)
1 perl(MouseX::NativeTraits::MethodProvider::CodeRef)
1 perl(MouseX::NativeTraits::MethodProvider::Counter)
1 perl(MouseX::NativeTraits::MethodProvider::HashRef)
1 perl(MouseX::NativeTraits::MethodProvider::Num)
1 perl(MouseX::NativeTraits::MethodProvider::Str)
1 perl(MouseX::NativeTraits::Num)
1 perl(MouseX::NativeTraits::Str)
1 perl-MouseX-NativeTraits = 1.09-1.fc23
Binary provides are Ok.
Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=10176885).
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items and provide new spec file.
Resolution: Package NOT approved.
Fixed build-requires Updated files are available on the same links. Spec file changes:
$ diff -u perl-MouseX-NativeTraits.spec{.old,}
--- perl-MouseX-NativeTraits.spec.old 2015-05-26 15:55:25.000000000 +0200
+++ perl-MouseX-NativeTraits.spec 2015-06-22 14:47:16.000000000 +0200
@@ -8,6 +8,10 @@
Source0: http://www.cpan.org/authors/id/G/GF/GFUJI/MouseX-NativeTraits-%{version}.tar.gz
Patch0: MouseX-NativeTraits-1.09-Disable-author-tests.patch
BuildArch: noarch
+BuildRequires: coreutils
+BuildRequires: findutils
+BuildRequires: make
+BuildRequires: sed
BuildRequires: perl
BuildRequires: perl(Any::Moose) >= 0.13
BuildRequires: perl(Data::Dumper)
@@ -26,7 +30,6 @@
BuildRequires: perl(Test::More) >= 0.88
BuildRequires: perl(Test::Mouse)
BuildRequires: perl(Tie::Hash)
-BuildRequires: perl(vars)
BuildRequires: perl(warnings)
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
Requires: perl(Mouse) >= 0.82
> TODO: Do not build-require `perl(vars)'. It's only required from bundled
> ./inc which is not used.
-BuildRequires: perl(vars)
Ok.
> FIX: Build-require coreutils (perl-MouseX-NativeTraits.spec:44).
+BuildRequires: coreutils
Ok.
> FIX: Build-require sed (perl-MouseX-NativeTraits.spec:45).
+BuildRequires: sed
Ok.
> FIX: Build-require findutils (perl-MouseX-NativeTraits.spec:46).
+BuildRequires: findutils
Ok.
> FIX: Build-require make (perl-MouseX-NativeTraits.spec:50).
+BuildRequires: make
Ok.
$ rpmlint perl-MouseX-NativeTraits.spec ../SRPMS/perl-MouseX-NativeTraits-1.09-1.fc23.src.rpm ../RPMS/noarch/perl-MouseX-NativeTraits-1.09-1.fc23.noarch.rpm
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.src: W: spelling-error %description -l en_US clearers -> clearer, cleaners, cleavers
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize
perl-MouseX-NativeTraits.noarch: W: spelling-error %description -l en_US clearers -> clearer, cleaners, cleavers
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.
Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=10177354). Ok.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-MouseX-NativeTraits Short Description: Extend your attribute interfaces for Mouse Upstream URL: http://search.cpan.org/dist/MouseX-NativeTraits/ Owners: jplesnik ppisar psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. |