Bug 1225109

The RSDL documentation is correct, and the <action> element is optional. The problem is that you are probably trying to invoke this action including the "Content-Type: application/xml" header, something like this:

---8<---
url="https://engine36.example.com/ovirt-engine/api"
user="admin@internal"
password="..."
connection_id="..."

curl \
--verbose \
--insecure \
--user "${user}:${password}" \
--header "Content-Type: application/xml" \
--request DELETE \
"${url}/storageconnections/${connection_id}"
--->8---

The implementation in the server side (see the StorageServerConnectionsResource interface) has two "remove" methods, one that receives no parameters (except the identifier of the storage connection) and one that receives the Action parameter:

  @DELETE
  @Path("{id}")
  public Response remove(@PathParam("id") String id);

  @DELETE
  @Consumes({ ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML })
  @Path("{id}")
  public Response remove(@PathParam("id") String id, Action action);

When you send the DELETE request with the Content-Type header and without the Action in the body, the server automatically selects the second method, because it is the only one that explicitly accepts the given content type. Then the server tries to deserialize the body to create the Action object, and it fails because there isn't a body, that is why you get the 400 code. Currently the correct way to send this request is without a Content-Type header.

---8<---
url="https://engine36.example.com/ovirt-engine/api"
user="admin@internal"
password="..."
connection_id="..."

curl \
--verbose \
--insecure \
--user "${user}:${password}" \
--request DELETE \
"${url}/storageconnections/${connection_id}"
--->8---

The "async" parameter is a matrix parameter in this case, so it must be part of the request URL:

  DELETE /storageconnections/{storageconnection:id};async

The fact that a wrong "remove" method is selected can be considered a bug, and it affects all the resources that have more than one "remove" method, not just the storage connections, so I'm making this an infra bug and targeting it for 4.x, as I think we can't fix it for 3.6.

Hi Juan, thank your for this response.

Did you run your example in 3.6? I've tried to not pass the body/content type as you mention in your example and is removing the object but it's returning a 500 error:

curl \
--insecure \
--request DELETE \
--verbose \
-u user@domain:password \
$url/api/storageconnections/21b9ffd2-a6e8-4158-98dc-f807b71977cd

result:

> DELETE /api/storageconnections/21b9ffd2-a6e8-4158-98dc-f807b71977cd HTTP/1.1
> Authorization: Basic YWRtaW5AaW50ZXJuYWw6MTIzNDU2
> User-Agent: curl/7.37.0
> Accept: */*
> 
< HTTP/1.1 500 Internal Server Error
< Date: Fri, 10 Jul 2015 14:00:10 GMT
< Content-Type: text/html; charset=UTF-8
< Content-Length: 135
< Vary: Accept-Encoding
< Connection: close
< 
* Closing connection 0
Could not find MessageBodyWriter for response object of type: org.ovirt.engine.api.mod

versions:
java_sdk-3.6.0.0.0.12.20150623.94212-1.x86_64
ovirt-engine-3.6.0-0.0.master.20150627185750.git6f063c1.el6.noarch

Try adding the "Accept: application/xml" header:

curl \
--insecure \
--request DELETE \
--header "Accept: application/xml" \
--verbose \
-u user@domain:password \
$url/api/storageconnections/21b9ffd2-a6e8-4158-98dc-f807b71977cd

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

It isn't 100% clear if the HTTP specification allows bodies in DELETE requests, but anyhow using them is bad practice.

In version 4 of the API all the DELETE methods that received an "action" as parameter have been removed. When a parameter is required it can now be specified as a matrix or query parameter, for example, to delete a storage domain specifying a host:

  DELETE /api/storagedomains/{storagedomainid};host=myhost

If the parameter is missing, then an error message will be returned:

  <fault>
    <reason>host parameter is missing</reason>
  </fault>

DELETE /api/storagedomains/{storagedomainid} returns fault 'parameter is missing'

DELETE /api/storagedomains/{storagedomainid}?host=xxx deletes storage sucessfully and returns status complete

both in Version 4 (without header "Version:..") and it ignores anything in the body, I tried other DELETE commands (vms,hosts,storagesessions,...) and all ignores body

verified in ovirt-engine-restapi-4.0.2.6-0.1.el7ev.noarch