Bug 1225328

Summary:	afr: unrecognized option in re-balance volfile
Product:	[Community] GlusterFS	Reporter:	Mohammed Rafi KC <rkavunga>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bperkins, bugs, gluster-bugs, pkarampu, ravishankar
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1228640 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:05:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1228640

Description Mohammed Rafi KC 2015-05-27 06:51:43 UTC

Description of problem:

Rebalance process logs a warning for some of the option defined in afr translator saying that option is unrecognized. 

Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:
1.create and start a volume
2.start rebalance process
3.

Actual results:

a warning in log for unrecognized options in volfile

Expected results:

should not be any unrecognized options

Additional info:

Comment 1 Mohammed Rafi KC 2015-05-27 06:59:52 UTC

<snip from log>

[2015-05-27 06:42:15.673134] I [dht-shared.c:598:dht_init] 0-patchy2-hot-dht: dht_init using commit hash 2871736852
[2015-05-27 06:42:15.675759] I [dht-shared.c:598:dht_init] 0-patchy2-cold-dht: dht_init using commit hash 2871736852
[2015-05-27 06:42:15.678491] W [graph.c:357:_log_if_unknown_option] 0-patchy2-hot-replicate-1: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678535] W [graph.c:357:_log_if_unknown_option] 0-patchy2-hot-replicate-0: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678562] W [graph.c:357:_log_if_unknown_option] 0-patchy2-cold-replicate-1: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678578] W [graph.c:357:_log_if_unknown_option] 0-patchy2-cold-replicate-0: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678645] I [client.c:2154:notify] 0-patchy2-client-0: parent translators are ready, attempting connect on transport
[2015-05-27 06:42:15.677862] I [event-epoll.c:629:event_dispatch_epoll_worker] 0-epoll: Started thread with index 2


</snip>

Comment 2 Anand Avati 2015-05-27 08:45:31 UTC

REVIEW: http://review.gluster.org/10935 (glusterd/ afr: remove the readdir-failover option) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 3 Anand Avati 2015-06-05 11:25:27 UTC

COMMIT: http://review.gluster.org/10935 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 02ccab9257ab36af281a4a610684a913dfa32d0f
Author: Ravishankar N <ravishankar>
Date:   Fri May 29 10:40:22 2015 +0530

    glusterd/ afr: remove the readdir-failover option from rebalance process
    
    Remove the "replicate*.readdir-failover=off" xlator option from
    rebalance process' runner arguments because this is the default behaviour in
    afr-v2. i.e. reaaddir failover happens only if it is a new readdir
    (offset=0). 'Continuing'readdirs are always wound on the same child
    where the first readdir had happened and if that child is down, the
    readdir fails.
    
    The option cannot be removed from glusterd_volopt_map because there is a
    chance of ending up in peer rejected state in a heterogenous cluster
    (typical upgrade scenario) due to volinfo checksum mismatch. TODO:come up with
    some warning message to the user for such deprecated options if a volume
    set is attempted.
    
    Change-Id: I6a33dc9fae7cccea8c5fd3d9de40d88d13ad3689
    BUG: 1225328
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/10935
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Anuradha Talur <atalur>
    Reviewed-by: Krishnan Parthasarathi <kparthas>

Comment 4 Nagaprasad Sathyanarayana 2015-10-25 14:41:40 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 5 Niels de Vos 2016-06-16 13:05:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user