Bug 122538

Summary: Rebuilding dies at patches applying if SELinux is turned off
Product: [Fedora] Fedora Reporter: Robert Scheck <redhat-bugzilla>
Component: util-linuxAssignee: Elliot Lee <sopwith>
Status: CLOSED WONTFIX QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideKeywords: EasyFix, SELinux
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-08-31 22:43:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
util-linux.spec.diff
none
util-linux-2.11z-03-krb5.patch
none
util-linux-2.12-nfssloppy.patch
none
mount-2.11y-selinux.patch
none
util-linux.spec.diff
none
mount-2.11y-selinux.patch
none
util-linux-2.12-nfssloppy.patch none

Description Robert Scheck 2004-05-05 16:38:33 UTC
Description of problem:
Rebuilding dies at patches applying if SELinux is turned off:

--- snipp ---
Patch #1020 (util-linux-2.11z-03-krb5.patch):
+ patch -p1 -b --suffix .krb5 -s
+ echo 'Patch #1040 (util-linux-2.12-nfs-mount.patch):'
Patch #1040 (util-linux-2.12-nfs-mount.patch):
+ patch -p1 -b --suffix .nfsmount -s
+ echo 'Patch #1001 (util-linux-2.12-nfssloppy.patch):'
Patch #1001 (util-linux-2.12-nfssloppy.patch):
+ patch -p1 -b --suffix .nfssloppy -s
2 out of 5 hunks FAILED -- saving rejects to file mount/nfsmount.c.rej
error: Bad exit status from /var/tmp/rpm-tmp.6940 (%prep)
--- snapp ---

Version-Release number of selected component (if applicable):
util-linux-2.12-18

How reproducible:
Everytime

Steps to Reproduce:
1. Get util-linux-2.12-18 from Fedora Development
2. Turn SELinux off
3. Rebuild it
4. Get the error
  
Actual results:
There has to be a better patch merging, that the patch applying works
everytime. I think the SELinux patch should be the last patch, that
is applied to avoid problems like this.

Expected results:
Rebuilding should work with and without SELinux support.

Comment 1 Elliot Lee 2004-05-13 19:07:46 UTC
Unfortunately, this type of change is not a high priority right now,
since SELinux is the future. You'll have to send a patch if you want
this to happen.

Comment 2 Robert Scheck 2004-05-13 20:04:31 UTC
Why did I already know that before? ;-)

Okay, the following changes make it working for me for both:

Comment 3 Robert Scheck 2004-05-13 20:06:02 UTC
Created attachment 100218 [details]
util-linux.spec.diff

Comment 4 Robert Scheck 2004-05-13 20:08:40 UTC
Created attachment 100219 [details]
util-linux-2.11z-03-krb5.patch

Comment 5 Robert Scheck 2004-05-13 20:09:14 UTC
Created attachment 100220 [details]
util-linux-2.12-nfssloppy.patch

Comment 6 Robert Scheck 2004-05-13 20:09:37 UTC
Created attachment 100221 [details]
mount-2.11y-selinux.patch

Comment 7 Elliot Lee 2004-05-26 22:50:26 UTC
As of util-linux-2.12a the SELinux patches are integrated into the
upstream sources, so turning off SELinux no longer makes sense for the
FC devel version.

Eek, and you did all that work too - I'm sorry! If there's still a
need to turn off selinux we can figure something out.

Comment 8 Robert Scheck 2004-06-26 18:06:31 UTC
Reopening, because that closing reason was only a nice alibi, 
Elliot... :-(

Turning off or on SELinux makes also sense for util-linux-2.12a at 
Fedora Core development.

I know, that non SELinux hasn't a high priority, so I did some patch
merging myself (as I already did it for 2.12) - working for me - and 
attaching them here, again.

Maybe you can apply now these changes really and not defer them? That 
would be very nice, thank you :-)

Comment 9 Robert Scheck 2004-06-26 18:08:14 UTC
Created attachment 101439 [details]
util-linux.spec.diff

Comment 10 Robert Scheck 2004-06-26 18:08:48 UTC
Created attachment 101440 [details]
mount-2.11y-selinux.patch

Comment 11 Robert Scheck 2004-06-26 18:09:32 UTC
Created attachment 101441 [details]
util-linux-2.12-nfssloppy.patch

Comment 12 Elliot Lee 2004-08-31 22:43:48 UTC
Sorry, I don't see the point anymore. Turning off SELinux feature
compilation doesn't make sense for Fedora Core development especially
since SELinux is on by default, so I don't see that there's still a
need for turning SELinux off. We can talk about it on IRC if you like.