Bug 1225424

Summary:	[Backup]: Misleading error message when glusterfind delete is given with non-existent volume
Product:	[Community] GlusterFS	Reporter:	Milind Changire <mchangir>
Component:	glusterfind	Assignee:	Milind Changire <mchangir>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	avishwan, khiremat, sanandpa
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1224046
Clones:	1225548 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:05:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1225548

Description Milind Changire 2015-05-27 10:45:35 UTC

+++ This bug was initially created as a clone of Bug #1224046 +++

Description of problem:
When an incorrect session name is given, it displays that the session name is invalid, or session not found. Similarly, it should give a related error message when an incorrect volume name is given.

Version-Release number of selected component (if applicable):
glusterfs-3.7.0-2.el6rhs.x86_64

How reproducible: Always

Additional info:

root@dhcp43-140 ~]# glusterfind delete 
usage: glusterfind delete [-h] [--debug] session volume
glusterfind delete: error: too few arguments
[root@dhcp43-140 ~]# glusterfind delete sess vol11
Failed to parse Volume Info: 'NoneType' object has no attribute 'findall'
[root@dhcp43-140 ~]# 
[root@dhcp43-140 ~]# glusterfind list
SESSION                   VOLUME                    SESSION TIME             
---------------------------------------------------------------------------
sess                      vol1                      2015-05-19 15:30:19      
[root@dhcp43-140 ~]# 

Expected: Glusterfind session 'sess' with 'vol11' not found

Comment 1 Anand Avati 2015-05-27 13:28:31 UTC

REVIEW: http://review.gluster.org/10945 (glusterfind: asserting volume presence) posted (#1) for review on master by Milind Changire (mchangir)

Comment 2 Anand Avati 2015-05-28 06:29:10 UTC

REVIEW: http://review.gluster.org/10945 (glusterfind: asserting volume presence) posted (#3) for review on master by Milind Changire (mchangir)

Comment 3 Anand Avati 2015-05-28 10:15:05 UTC

REVIEW: http://review.gluster.org/10945 (tools/glusterfind: verifying volume presence) posted (#5) for review on master by Milind Changire (mchangir)

Comment 4 Anand Avati 2015-06-02 07:19:54 UTC

REVIEW: http://review.gluster.org/10945 (tools/glusterfind: verifying volume presence) posted (#6) for review on master by Milind Changire (mchangir)

Comment 5 Anand Avati 2015-06-03 06:08:19 UTC

REVIEW: http://review.gluster.org/10945 (tools/glusterfind: verifying volume presence) posted (#7) for review on master by Milind Changire (mchangir)

Comment 6 Anand Avati 2015-06-04 07:08:52 UTC

COMMIT: http://review.gluster.org/10945 committed in master by Venky Shankar (vshankar) 
------
commit c2898f040937492c69a603ab3605cbd441e1e1f3
Author: Milind Changire <mchangir>
Date:   Wed May 27 16:50:09 2015 +0530

    tools/glusterfind: verifying volume presence
    
    An invalid volume name passed to "pre", "post" and  "delete"
    operations throws up unfriendly errors. This patch presents
    friendly error messages.
    
    Change-Id: I233809653379b80b34c2e74c0b6f4fe502c8961e
    BUG: 1225424
    Signed-off-by: Milind Changire <mchangir>
    Reviewed-on: http://review.gluster.org/10945
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Aravinda VK <avishwan>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:47:03 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:05:25 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user