Bug 1225428
Summary: | Searching in templates return database error | ||
---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Karolína Hajná <khajna> |
Component: | ovirt-engine | Assignee: | Shmuel Melamud <smelamud> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | sefi litmanovich <slitmano> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.6.0 | CC: | bcholler, gklein, istein, lpeer, lsurette, michal.skrivanek, oourfali, pstehlik, rbalakri, Rhev-m-bugs, rick.beldin, srevivo, ykaul |
Target Milestone: | ovirt-3.6.0-rc | ||
Target Release: | 3.6.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-04-20 01:38:29 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Karolína Hajná
2015-05-27 11:00:00 UTC
this part looks wrong: ... templates storage domain.template version name, template version number like '%%%' or ... template_version_name is not compared to any value, and template_version_number is not a string at all, i dont think it should be queried here at all not sure if infra or virt, Eli, please let me know what you find/decide as a workaround i recommend not to use this kind of "search all fields for string" you can search for string in specific fields, like: curl -k -u admin@internal -i -H "Accept: application/xml" https://{engine_ip}/api/templates\;from\=\?search\=name\=* (In reply to Omer Frenkel from comment #1) > this part looks wrong: > > ... > templates storage domain.template version name, template version number like > '%%%' or > ... > > template_version_name is not compared to any value, and > template_version_number is not a string at all, i dont think it should be > queried here at all > > not sure if infra or virt, Eli, please let me know what you find/decide > I think its virt origin : backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java code : columnNameDict.put(VERSION_NAME_AND_NUMBER, "template_version_name, template_version_number"); AFAIK, the search engine does not support here multiple columns, especially when one is varchar and the other is int so the "like" operation will fail. If both version name and number are needed here, maybe add a computed column to the view that is varchar and concat both and then use this column here ok, thanks. i dont think we need a computed column, currently it doesnt look like the sorting for the version column in the ui works well.. i think it should be on version name only, should fix both search and sorting issues. moving to virt ovirt-3.6.0-3 release Verified with ovirt-engine-3.6.0-0.0.master.20150627185750.git6f063c1.el6.noarch according the description: curl -k -u admin@internal -i -H "Accept: application/xml" https://{engine_ip}/api/templates\;from\=\?search\=name\=* returned all the templates as expected. Problem seen on RHEV 3.5.3. as well. did not re produce on rhevm-3.5.5-0.1.el6ev.noarch so need to open z-stream bz. |