Bug 1225492
| Summary: | XHTML files contain errorprone javascript calls | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Libor Zoubek <lzoubek> |
| Component: | Content | Assignee: | Libor Zoubek <lzoubek> |
| Status: | CLOSED ERRATA | QA Contact: | Filip Brychta <fbrychta> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | JON 3.3.2 | CC: | fbrychta, spinder, theute |
| Target Milestone: | CR01 | Keywords: | Triaged |
| Target Release: | JON 3.3.3 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-30 16:43:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
branch: master link: https://github.com/rhq-project/rhq/commit/572ff6018 time: 2015-05-27 15:37:14 +0200 commit: 572ff60186bae13f6a2701a1932331f75f54fad8 author: Libor Zoubek - lzoubek message: Bug 1225492 - XHTML files contain errorprone javascript calls errorprone calls replaced with safe function Available for test with 3.3.3 ER01 build: https://brewweb.devel.redhat.com/buildinfo?buildID=446732 *Note: jon-server-patch-3.3.0.GA.zip maps to ER01 build of jon-server-3.3.0.GA-update-03.zip. Checked content of jon-server-3.3.0.GA/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-portal.war/rhq/content/contentProvider-plain.xhtml and it does NOT contain changes from commit in comment 1. Looking at comment 3 it seems that incorrect commit was cherry picked Available for test with following build: https://brewweb.devel.redhat.com/buildinfo?buildID=448923 *Note: jon-server-patch-3.3.0.GA.zip maps to CR01 build of jon-server-3.3.0.GA-update-03.zip. Verified on Version : 3.3.0.GA Update 03 Build Number : edc324f:119e8f4 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1525.html |
Description of problem: When fixing several content related issues I found we use this javascripts in our *-plain.xhtml document.getElementById('pollerForm').setAttribute('action', 'contentProvider-plain.xhtml'); document.getElementById('contentProviderDetailsForm').setAttribute('action', 'contentProvider-plain.xhtml'); document.getElementById('contentSourceSyncResultsListForm').setAttribute('action', 'contentProvider-plain.xhtml'); document.getElementById('contentSourceRepoListForm').setAttribute('action', 'contentProvider-plain.xhtml'); This is errorprone, because some of forms are rendered under certain condition. If for example form with id pollerForm is not rendered, then whole javascript fails due to first error and 'action' attributes are not set to the rest of forms. Actual results: somethimes there are errors in browser dev console for example when viewing content source Expected results: no exceptions in JS dev console Additional info: